[BB-9101] Set active courses as default in studio home

[pkulkark]

Description

This PR sets active courses as the default option in dropdown, instead of all courses, in the studio home page.

Supporting information

OpenCraft's Internal Jira task: BB-9101

Testing instructions

1. Deploy this branch and navigate to the mfe home page.
2. Verify that the default option selected for the course-type dropdown is "Active" and not "All Courses".

[openedx-webhooks]

Thanks for the pull request, @pkulkark!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (82a3b7c) to head (85d498d).

Files with missing lines	Patch %	Lines
src/studio-home/hooks.jsx	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   92.34%   92.35%   +0.01%     
==========================================
  Files        1023     1023              
  Lines       18877    18877              
  Branches     4023     4025       +2     
==========================================
+ Hits        17432    17434       +2     
- Misses       1376     1377       +1     
+ Partials       69       66       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bradenmacdonald]

@pkulkark Was there any product discussion about this change? If not, I think we'll want the product WG to confirm this default is better.

[pkulkark]

@bradenmacdonald I'm not sure if there was. How do I bring it to the product WG?

[bradenmacdonald]

@pkulkark It says in the bot's comment above: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3875962884/How+to+submit+an+open+source+contribution+for+Product+Review#Product-Review-Process

[pkulkark]

@bradenmacdonald I created the proposal in the wiki but I don't seem to have access to create the corresponding github ticket in https://github.com/openedx/platform-roadmap/issues/new?assignees=&labels=&projects=&template=01-roadmap-issue.yml&title=Put+Initiative+Name+Here. Do I need to request access somewhere?

[bradenmacdonald]

@pkulkark As this is such a small change, I think you can just use this PR as the github ticket. You can probably skip the wiki proposal too TBH, and just ping the WG on Slack #wg-product-core.

[pkulkark]

Thanks @bradenmacdonald. Posted on the slack channel.

[ali-hugo]

@pkulkark Thanks for this work. It seems like a definite improvement to me, so gets my vote!

You'll see that I've pinged a few product people on Slack for their review. Hopefully we can move this forward soon.

[crathbun428]

On first blush, this change makes sense to me.

However, I've got 2-3 questions:

• Two reasons I think defaulting to all courses may make sense (maybe there is information out there that refutes my two thoughts below?):
  • Is it common to re-run an archived course so common that users would want to see all courses by default - I'm not sure if this is the case?
  • Does the search bar on this page return all results or only those for Active courses if the active filter is applied? I'd assume it would only return Active courses - will this confuse users who land on this page used to it showing all courses and go directly to search? Maybe not, but I figured I'd raise the question to see if this was tested with users/informed by user feedback.
• It looks like we just did a studio home facelift - any reason why All Courses was the chosen default for Redwood? Is it user feedback we're using to decide that Active courses are what users are looking for/expecting when they land on this page?

[pkulkark]

@crathbun428 I'll try to answer to the best of my knowledge.

Is it common to re-run an archived course so common that users would want to see all courses by default - I'm not sure if this is the case?

I'm not sure about how common it is but if you create a re-run, I think that would have an active status and show up in the list.

Does the search bar on this page return all results or only those for Active courses if the active filter is applied? I'd assume it would only return Active courses - will this confuse users who land on this page used to it showing all courses and go directly to search? Maybe not, but I figured I'd raise the question to see if this was tested with users/informed by user feedback.

The filter is maintained for search results i.e it will only return active courses if the active filter is applied. The dropdown shows "Active" by default so there shouldn't be much confusion around what is being showed. And users can still choose "All courses" option in the dropdown if they want to search through all courses.

It looks like we just did a studio home facelift - any reason why All Courses was the chosen default for Redwood? Is it user feedback we're using to decide that Active courses are what users are looking for/expecting when they land on this page?

I believe it just reflects the API behaviour. With no params specified, the API returns all results. Previously there were separate tabs for active and archived courses, and each would apply the corresponding param to the API request.
Yes, this was a user feedback/request from one of our clients.

[crathbun428]

Thank you for responding to my questions, @pkulkark!

In digging into the Studio Home facelift further, it looks like there are some designs for the Studio Home facelift that have yet to be implemented to the Studio that may change how we want this filter to behave. See how designers imagined we might further improve this page, below:

Although there are designs, we need a team to finish implementing them - there is currently not a team in place to deliver these improvements to Studio Home. Depending on how this gets implemented - the change you propose may be reversed in favor of showing all courses by default and allowing the user to collapse/ expand each course to hide/show archived runs. Because of this, it may make sense to table this improvement with the idea that a slightly different approach may be needed by the attached design. Definitely open to chatting more if this is work your team would be interested in delivering.