fix: Set active courses as default in studio home

openedx · Sep 3, 2024 · f76ac07 · f76ac07
1 parent 735d978
commit f76ac07
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/src/studio-home/tabs-section/courses-tab/courses-filters/__snapshots__/index.test.jsx.snap b/src/studio-home/tabs-section/courses-tab/courses-filters/__snapshots__/index.test.jsx.snap
@@ -81,7 +81,7 @@ exports[`CoursesFilters snapshot 1`] = `
         id="dropdown-toggle-course-type-menu"
         type="button"
       >
-        All courses
+        Active
       </button>
     </div>
     <div

diff --git a/...n/courses-tab/courses-filters/courses-types-filter-menu/__snapshots__/index.test.jsx.snap b/...n/courses-tab/courses-filters/courses-types-filter-menu/__snapshots__/index.test.jsx.snap
@@ -16,7 +16,7 @@ exports[`CoursesTypesFilterMenu snapshot 1`] = `
       id="dropdown-toggle-course-type-menu"
       type="button"
     >
-      All courses
+      Active
     </button>
   </div>
 </div>

diff --git a/src/studio-home/tabs-section/courses-tab/courses-filters/courses-types-filter-menu/index.jsx b/src/studio-home/tabs-section/courses-tab/courses-filters/courses-types-filter-menu/index.jsx
@@ -39,7 +39,7 @@ const CoursesTypesFilterMenu = ({ onItemMenuSelected }) => {
       id="dropdown-toggle-course-type-menu"
       menuItems={courseTypes}
       onItemMenuSelected={handleCourseTypeSelected}
-      defaultItemSelectedText={intl.formatMessage(messages.coursesTypesFilterMenuAllCurses)}
+      defaultItemSelectedText={intl.formatMessage(messages.coursesTypesFilterMenuActiveCurses)}
     />
   );
 };

diff --git a/...io-home/tabs-section/courses-tab/courses-filters/courses-types-filter-menu/index.test.jsx b/...io-home/tabs-section/courses-tab/courses-filters/courses-types-filter-menu/index.test.jsx
@@ -60,11 +60,11 @@ describe('CoursesTypesFilterMenu', () => {
     const { defaultMessage: activeCoursesMenuText } = message.coursesTypesFilterMenuActiveCurses;
     const { defaultMessage: allCoursesMenuText } = message.coursesTypesFilterMenuAllCurses;
     const { defaultMessage: archiveCoursesMenuText } = message.coursesTypesFilterMenuArchivedCurses;
-    const activeCoursesMenuItem = screen.getByText(activeCoursesMenuText);
-    const allCoursesMenuItem = screen.getByTestId('item-menu-all-courses');
+    const activeCoursesMenuItem = screen.getByTestId('item-menu-active-courses');
+    const allCoursesMenuItem = screen.getByText(allCoursesMenuText);
     const archiveCoursesMenuItem = screen.getByText(archiveCoursesMenuText);
-    expect(activeCoursesMenuItem).toBeInTheDocument();
-    expect(allCoursesMenuItem.textContent).toContain(allCoursesMenuText);
+    expect(activeCoursesMenuItem.textContent).toContain(activeCoursesMenuText);
+    expect(allCoursesMenuItem).toBeInTheDocument();
     expect(archiveCoursesMenuItem).toBeInTheDocument();
   });
 

diff --git a/src/studio-home/tabs-section/courses-tab/courses-filters/index.jsx b/src/studio-home/tabs-section/courses-tab/courses-filters/index.jsx
@@ -43,7 +43,7 @@ const CoursesFilters = ({
     oldestCourses: { ...baseFilters, order: 'created' },
   });
 
-  const handleMenuFilterItemSelected = (filterType) => {
+  const handleMenuFilterItemSelected = (filterType = 'activeCourses') => {
     const baseFilters = {
       currentPage: 1,
       search,