Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch from libsass-python to dart-sass #31593

Closed
wants to merge 5 commits into from
Closed

build: switch from libsass-python to dart-sass #31593

wants to merge 5 commits into from

Commits on Jan 19, 2023

  1. build: upgrade from libsass-python to dart-sass

    @kdmccormick
    kdmccormick committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    27b7b9b View commit details
    Browse the repository at this point in the history

  2. temp: hide sass warnings so that we can see the errors

    @kdmccormick
    kdmccormick committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    5a9f504 View commit details
    Browse the repository at this point in the history

  3. build: djoy and abutterworth's fixes for libsass upgrade 

    Original contents:

chore: update libsass to v0.20.1

Updating libsass to latest.  Libsass is now stricter about undefined placeholder mixins, and so we had to mark a bunch of broken code as !optional.

We had upgraded libsass until it broke with this version: https://github.com/sass/libsass/releases/tag/3.3.3

That release of libsass included a fix for a missing error on undefined placeholders.

Our code was always wrong, now it just complains.  This PR fixes it.

fix: some more extend issues

fix: add needed functions before bootstrap variables

No longer rely on themes to import bootstrap functions
    @davidjoy @kdmccormick
    davidjoy authored and kdmccormick committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    866fd24 View commit details
    Browse the repository at this point in the history

  4. build: kyle's fixes: add more "!optional" to @extend

    @kdmccormick
    kdmccormick committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4e7afbc View commit details
    Browse the repository at this point in the history

  5. build: kyle's fixes: scss errors surfaced by dart-sass

    @kdmccormick
    kdmccormick committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    e785892 View commit details
    Browse the repository at this point in the history