build: switch from libsass-python to dart-sass #31593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original contents: chore: update libsass to v0.20.1 Updating libsass to latest. Libsass is now stricter about undefined placeholder mixins, and so we had to mark a bunch of broken code as !optional. We had upgraded libsass until it broke with this version: https://github.com/sass/libsass/releases/tag/3.3.3 That release of libsass included a fix for a missing error on undefined placeholders. Our code was always wrong, now it just complains. This PR fixes it. fix: some more extend issues fix: add needed functions before bootstrap variables No longer rely on themes to import bootstrap functions
1 task
|
It looks like any newer compiler will raise many errors for our SCSS code, which we can't fix right now. Closed in favor of #31616. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBD
Supporting information
Part of openedx-unsupported/wg-developer-experience#150
Testing instructions
TBD
Deadline
TBD
Other information
TBD