Altering client id and secret in sap configuration #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameenfatima78
approved these changes
Aug 29, 2024
zamanafzal
reviewed
Aug 29, 2024
This was referenced Aug 29, 2024
zamanafzal
approved these changes
Aug 29, 2024
…Khan/Altering-Client-ID-And-Secret-In-SAP-Configuration
MueezKhan246
deleted the
MueezKhan/Altering-Client-ID-And-Secret-In-SAP-Configuration
branch
MueezKhan246
added a commit
that referenced
this pull request
Sep 2, 2024
…dentials nullable" in #2219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
altered decrypted_secret field type to be encrypted and made unencrypted credentials nullable so refernces can be removed from test cases.
this PR can be merged as it has no dependency.
JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8972