Skip to content

Commit

Permalink
Altering client id and secret in sap configuration (#2219)
Browse files Browse the repository at this point in the history
* feat: altered decrypted_secret to be encrypted and made credentials nullable
  • Loading branch information
MueezKhan246 committed Aug 30, 2024
1 parent eac8dc5 commit 707fded
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Unreleased
----------
* nothing unreleased

[4.23.15]
----------
* feat: altered decrypted_secret to be encrypted and made credentials nullable

[4.23.14]
----------
* feat: populate encrypted client id and secret for canvas integration and remove references to unencrypted fields
Expand Down
2 changes: 1 addition & 1 deletion enterprise/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Your project description goes here.
"""

__version__ = "4.23.14"
__version__ = "4.23.15"
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Generated by Django 3.2.23 on 2024-08-29 09:10

from django.db import migrations, models
import fernet_fields.fields


class Migration(migrations.Migration):

dependencies = [
('sap_success_factors', '0017_auto_20240823_0936'),
]

operations = [
migrations.AlterField(
model_name='sapsuccessfactorsenterprisecustomerconfiguration',
name='decrypted_secret',
field=fernet_fields.fields.EncryptedCharField(blank=True, default='', help_text='The encrypted OAuth client secret. It will be encrypted when stored in the database.', max_length=255, null=True, verbose_name='Encrypted Client Secret'),
),
migrations.AlterField(
model_name='sapsuccessfactorsenterprisecustomerconfiguration',
name='key',
field=models.CharField(blank=True, default='', help_text='OAuth client identifier.', max_length=255, null=True, verbose_name='Client ID'),
),
migrations.AlterField(
model_name='sapsuccessfactorsenterprisecustomerconfiguration',
name='secret',
field=models.CharField(blank=True, default='', help_text='OAuth client secret.', max_length=255, null=True, verbose_name='Client Secret'),
),
]
8 changes: 5 additions & 3 deletions integrated_channels/sap_success_factors/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
blank=True,
default='',
verbose_name="Client ID",
help_text=_("OAuth client identifier.")
help_text=_("OAuth client identifier."),
null=True
)

decrypted_key = EncryptedCharField(
Expand Down Expand Up @@ -120,10 +121,11 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
blank=True,
default='',
verbose_name="Client Secret",
help_text=_("OAuth client secret.")
help_text=_("OAuth client secret."),
null=True
)

decrypted_secret = models.CharField(
decrypted_secret = EncryptedCharField(
max_length=255,
blank=True,
default='',
Expand Down

0 comments on commit 707fded

Please sign in to comment.