Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ruby 3.1 ci pipeline for tests #418

Closed
wants to merge 1 commit into from
Closed

feat: add ruby 3.1 ci pipeline for tests #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
ruby-version: ['3.0.4']
ruby-version: ['3.0.4', '3.1.0']
mongodb-version: ['4.2.14']
Copy link
Member

@ghassanmas ghassanmas Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to support both?

I think we need to remove 3.0.4 and regenerate Gemfile.lock ( currently generated for Ruby 2) note currenlty we have Gemfile.lock ( currently generated for Ruby 2) and Gemfile3.lock (Currenlty For ruby 3..0.4) I think we longer need to have both, unless this still support Ruby 2 and we need to regeerate one of them for 3.0.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ghassanmas
We do not need to support both. We will have a cleanup of the Gemfile after the 3.1.0 upgrade work is complete and tested.
Then we will have a single Gemfile for ruby 3.1.0, and single CI for 3.1.0. There will be a followup PR for that!

include:
- ruby-version: 3.0.4
gemfile: Gemfile3
allow-failure: false
- ruby-version: 3.1.0
gemfile: Gemfile3
allow-failure: false
env:
SEARCH_SERVER_ES7: http://localhost:9200
MONGOHQ_URL: mongodb://localhost:27017/cs_comments_service_test
Expand Down Expand Up @@ -54,7 +57,9 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true

- name: Install packages required
run: sudo apt-get install libxslt-dev libxml2-dev

- name: Install dependencies
run: bundle install
Expand Down