-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ruby 3.1 ci pipeline for tests #418
Conversation
6b1f02e
to
52c4fdb
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 58 58
Lines 4562 4562
=======================================
Hits 4386 4386
Misses 176 176 ☔ View full report in Codecov by Sentry. |
4946f2f
to
94032f2
Compare
94032f2
to
bcdfc8c
Compare
bcdfc8c
to
dc55d81
Compare
@@ -13,12 +13,15 @@ jobs: | |||
runs-on: ubuntu-20.04 | |||
strategy: | |||
matrix: | |||
ruby-version: ['3.0.4'] | |||
ruby-version: ['3.0.4', '3.1.0'] | |||
mongodb-version: ['4.2.14'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to support both?
I think we need to remove 3.0.4
and regenerate Gemfile.lock
( currently generated for Ruby 2) note currenlty we have Gemfile.lock
( currently generated for Ruby 2) and Gemfile3.lock
(Currenlty For ruby 3..0.4) I think we longer need to have both, unless this still support Ruby 2 and we need to regeerate one of them for 3.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ghassanmas
We do not need to support both. We will have a cleanup of the Gemfile
after the 3.1.0
upgrade work is complete and tested.
Then we will have a single Gemfile
for ruby 3.1.0
, and single CI for 3.1.0
. There will be a followup PR for that!
Just want to notify everybody about this PR. Let's complete it and backport to quince. |
Do we plan to move forward to Ruby 3.1? |
Closed because of this - #426 |
INF-1008
Description
Add Ruby 3.1 CI test pipeline.