Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruby 3.1 ci pipeline for tests #418

Closed
wants to merge 1 commit into from

Conversation

saadyousafarbi
Copy link
Contributor

INF-1008

Description

Add Ruby 3.1 CI test pipeline.

@saadyousafarbi saadyousafarbi force-pushed the saad/INF-1008 branch 2 times, most recently from 6b1f02e to 52c4fdb Compare September 27, 2023 08:47
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (81e11c7) 96.14% compared to head (1efbdb9) 96.14%.

❗ Current head 1efbdb9 differs from pull request most recent head dc55d81. Consider uploading reports for the commit dc55d81 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files          58       58           
  Lines        4562     4562           
=======================================
  Hits         4386     4386           
  Misses        176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -13,12 +13,15 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
ruby-version: ['3.0.4']
ruby-version: ['3.0.4', '3.1.0']
mongodb-version: ['4.2.14']
Copy link
Member

@ghassanmas ghassanmas Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to support both?

I think we need to remove 3.0.4 and regenerate Gemfile.lock ( currently generated for Ruby 2) note currenlty we have Gemfile.lock ( currently generated for Ruby 2) and Gemfile3.lock (Currenlty For ruby 3..0.4) I think we longer need to have both, unless this still support Ruby 2 and we need to regeerate one of them for 3.0.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ghassanmas
We do not need to support both. We will have a cleanup of the Gemfile after the 3.1.0 upgrade work is complete and tested.
Then we will have a single Gemfile for ruby 3.1.0, and single CI for 3.1.0. There will be a followup PR for that!

@cmltaWt0
Copy link

cmltaWt0 commented Jan 8, 2024

Just want to notify everybody about this PR. Let's complete it and backport to quince.

@cmltaWt0
Copy link

cmltaWt0 commented Feb 5, 2024

Do we plan to move forward to Ruby 3.1?
The end of life for 3.0 is 31 Mar 2024.

@saadyousafarbi
Copy link
Contributor Author

Closed because of this - #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants