Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated to python 3.12 #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+71 −71
Open

feat: updated to python 3.12 #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc11490
feat: updated to python 3.12
BilalQamar95 Oct 23, 2024
6567c3b
chore: resolved pylint errors
BilalQamar95 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
os:
- ubuntu-latest
python-version: ['3.11']
python-version: ['3.12']
toxenv: [ unittest, quality ]
steps:
- uses: actions/checkout@v4
Expand All @@ -34,7 +34,7 @@ jobs:
run: tox

- name: Run Coverage
if: matrix.python-version == '3.8' && matrix.toxenv=='unittest'
if: matrix.python-version == '3.12' && matrix.toxenv=='unittest'
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: setup python
uses: actions/setup-python@v2
with:
python-version: 3.11
python-version: 3.12

- name: Install pip
run: pip install -U pip wheel
Expand Down
1 change: 1 addition & 0 deletions ccx_keys/tests/test_ccx_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ def test_missing_block_id(self, url):
('org', 'course', 'run', '1', 'category', 'name:more_name', None),
)
@ddt.unpack
# pylint: disable=too-many-positional-arguments
def test_valid_locations(self, org, course, run, ccx, category, name, revision):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_valid_locations(self, org, course, run, ccx, category, name, revision):
def test_valid_locations(self, org, course, run, ccx, category, name, revision): # pylint: disable=too-many-positional-arguments

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing the pylint disable above the function would be better here imo because the function has a long signature with seven arguments. Adding an inline comment would crowd the line, making it harder to read. An above-line comment maintains clarity and improves readability for reviewers and maintainers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it in the upgrade requirements PR. You can simply rebase the PR to get it resolved
5c7cef1#diff-4a1e5a86c548b14ce47668a70a21cf73c0d23eb4fb780ad87e2bc3f1e596ed9fR308

course_key = CCXLocator(org=org, course=course, run=run, branch=revision, ccx=ccx)
locator = CCXBlockUsageLocator(course_key, block_type=category, block_id=name, )
Expand Down
10 changes: 5 additions & 5 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# make upgrade
#
dnspython==2.6.1
dnspython==2.7.0
# via pymongo
edx-opaque-keys==2.10.0
edx-opaque-keys==2.11.0
# via -r requirements/base.in
pbr==6.0.0
pbr==6.1.0
# via stevedore
pymongo==4.8.0
pymongo==4.10.1
# via edx-opaque-keys
six==1.16.0
# via -r requirements/base.in
Expand Down
14 changes: 7 additions & 7 deletions requirements/ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# make upgrade
Expand All @@ -10,25 +10,25 @@ chardet==5.2.0
# via tox
colorama==0.4.6
# via tox
distlib==0.3.8
distlib==0.3.9
# via virtualenv
filelock==3.15.4
filelock==3.16.1
# via
# tox
# virtualenv
packaging==24.1
# via
# pyproject-api
# tox
platformdirs==4.2.2
platformdirs==4.3.6
# via
# tox
# virtualenv
pluggy==1.5.0
# via tox
pyproject-api==1.7.1
pyproject-api==1.8.0
# via tox
tox==4.18.0
tox==4.23.2
# via -r requirements/ci.in
virtualenv==20.26.3
virtualenv==20.27.0
# via tox
42 changes: 21 additions & 21 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# make upgrade
#
astroid==3.2.4
astroid==3.3.5
# via
# -r requirements/test.txt
# pylint
# pylint-celery
build==1.2.1
build==1.2.2.post1
# via
# -r requirements/pip-tools.txt
# pip-tools
Expand Down Expand Up @@ -44,28 +44,28 @@ colorama==0.4.6
# -r requirements/ci.txt
# -r requirements/test.txt
# tox
coverage==7.6.1
coverage==7.6.4
# via -r requirements/test.txt
ddt==1.7.2
# via -r requirements/test.txt
dill==0.3.8
dill==0.3.9
# via
# -r requirements/test.txt
# pylint
distlib==0.3.8
distlib==0.3.9
# via
# -r requirements/ci.txt
# -r requirements/test.txt
# virtualenv
dnspython==2.6.1
dnspython==2.7.0
# via
# -r requirements/test.txt
# pymongo
edx-lint==5.3.7
edx-lint==5.4.0
# via -r requirements/test.txt
edx-opaque-keys==2.10.0
edx-opaque-keys==2.11.0
# via -r requirements/test.txt
filelock==3.15.4
filelock==3.16.1
# via
# -r requirements/ci.txt
# -r requirements/test.txt
Expand All @@ -85,7 +85,7 @@ jinja2==3.1.4
# code-annotations
lazy-object-proxy==1.10.0
# via -r requirements/test.txt
markupsafe==2.1.5
markupsafe==3.0.2
# via
# -r requirements/test.txt
# jinja2
Expand All @@ -104,13 +104,13 @@ packaging==24.1
# pyproject-api
# pytest
# tox
pbr==6.0.0
pbr==6.1.0
# via
# -r requirements/test.txt
# stevedore
pip-tools==7.4.1
# via -r requirements/pip-tools.txt
platformdirs==4.2.2
platformdirs==4.3.6
# via
# -r requirements/ci.txt
# -r requirements/test.txt
Expand All @@ -125,7 +125,7 @@ pluggy==1.5.0
# tox
pycodestyle==2.12.1
# via -r requirements/test.txt
pylint==3.2.6
pylint==3.3.1
# via
# -r requirements/test.txt
# edx-lint
Expand All @@ -136,7 +136,7 @@ pylint-celery==0.3
# via
# -r requirements/test.txt
# edx-lint
pylint-django==2.5.5
pylint-django==2.6.1
# via
# -r requirements/test.txt
# edx-lint
Expand All @@ -145,21 +145,21 @@ pylint-plugin-utils==0.8.2
# -r requirements/test.txt
# pylint-celery
# pylint-django
pymongo==4.8.0
pymongo==4.10.1
# via
# -r requirements/test.txt
# edx-opaque-keys
pyproject-api==1.7.1
pyproject-api==1.8.0
# via
# -r requirements/ci.txt
# -r requirements/test.txt
# tox
pyproject-hooks==1.1.0
pyproject-hooks==1.2.0
# via
# -r requirements/pip-tools.txt
# build
# pip-tools
pytest==8.3.2
pytest==8.3.3
# via -r requirements/test.txt
python-slugify==8.0.4
# via
Expand All @@ -186,15 +186,15 @@ tomlkit==0.13.2
# via
# -r requirements/test.txt
# pylint
tox==4.18.0
tox==4.23.2
# via
# -r requirements/ci.txt
# -r requirements/test.txt
typing-extensions==4.12.2
# via
# -r requirements/test.txt
# edx-opaque-keys
virtualenv==20.26.3
virtualenv==20.27.0
# via
# -r requirements/ci.txt
# -r requirements/test.txt
Expand Down
6 changes: 3 additions & 3 deletions requirements/pip-tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# make upgrade
#
build==1.2.1
build==1.2.2.post1
# via pip-tools
click==8.1.7
# via pip-tools
packaging==24.1
# via build
pip-tools==7.4.1
# via -r requirements/pip-tools.in
pyproject-hooks==1.1.0
pyproject-hooks==1.2.0
# via
# build
# pip-tools
Expand Down
4 changes: 2 additions & 2 deletions requirements/pip.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# make upgrade
Expand All @@ -10,5 +10,5 @@ wheel==0.44.0
# The following packages are considered to be unsafe in a requirements file:
pip==24.2
# via -r requirements/pip.in
setuptools==73.0.1
setuptools==75.2.0
# via -r requirements/pip.in
18 changes: 9 additions & 9 deletions requirements/quality.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# make upgrade
#
astroid==3.2.4
astroid==3.3.5
# via
# pylint
# pylint-celery
Expand All @@ -17,25 +17,25 @@ click-log==0.4.0
# via edx-lint
code-annotations==1.8.0
# via edx-lint
dill==0.3.8
dill==0.3.9
# via pylint
edx-lint==5.3.7
edx-lint==5.4.0
# via -r requirements/quality.in
isort==5.13.2
# via pylint
jinja2==3.1.4
# via code-annotations
markupsafe==2.1.5
markupsafe==3.0.2
# via jinja2
mccabe==0.7.0
# via pylint
pbr==6.0.0
pbr==6.1.0
# via stevedore
platformdirs==4.2.2
platformdirs==4.3.6
# via pylint
pycodestyle==2.12.1
# via -r requirements/quality.in
pylint==3.2.6
pylint==3.3.1
# via
# -r requirements/quality.in
# edx-lint
Expand All @@ -44,7 +44,7 @@ pylint==3.2.6
# pylint-plugin-utils
pylint-celery==0.3
# via edx-lint
pylint-django==2.5.5
pylint-django==2.6.1
# via edx-lint
pylint-plugin-utils==0.8.2
# via
Expand Down
Loading
Loading