feat: updated to python 3.12 #127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 4 4
Lines 226 226
Branches 13 8 -5
=======================================
Hits 221 221
Misses 5 5 ☔ View full report in Codecov by Sentry. |
| @@ -309,6 +309,7 @@ def test_missing_block_id(self, url): | |||
| ('org', 'course', 'run', '1', 'category', 'name:more_name', None), | |||
| ) | |||
| @ddt.unpack | |||
| # pylint: disable=too-many-positional-arguments | |||
| def test_valid_locations(self, org, course, run, ccx, category, name, revision): | |||
There was a problem hiding this comment.
| def test_valid_locations(self, org, course, run, ccx, category, name, revision): | |
| def test_valid_locations(self, org, course, run, ccx, category, name, revision): # pylint: disable=too-many-positional-arguments |
There was a problem hiding this comment.
Placing the pylint disable above the function would be better here imo because the function has a long signature with seven arguments. Adding an inline comment would crowd the line, making it harder to read. An above-line comment maintains clarity and improves readability for reviewers and maintainers.
There was a problem hiding this comment.
Fixed it in the upgrade requirements PR. You can simply rebase the PR to get it resolved
5c7cef1#diff-4a1e5a86c548b14ce47668a70a21cf73c0d23eb4fb780ad87e2bc3f1e596ed9fR308
Description
For details, see tracking issue #120