Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add i18n_js_namespace to support atlas - FC-0012 #81

Closed
wants to merge 1 commit into from
Closed

feat: add i18n_js_namespace to support atlas - FC-0012 #81

wants to merge 1 commit into from

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Feb 28, 2024 •
edited
Loading

Implement OEP-58 JavaScript translations

Details:

Testing

Local tutor 17.0.2

  • translations are still working including JS translations
    Screenshot from 2024-02-28 11-15-04

References

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 28, 2024
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.i18n_js_namespace branch 2 times, most recently from ad2c726 to 19ae294 Compare February 28, 2024 08:18
@shadinaif
Copy link
Contributor Author

@OmarIthawi please review

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.i18n_js_namespace branch from 19ae294 to f8a1d61 Compare February 28, 2024 08:23
@shadinaif shadinaif mentioned this pull request Feb 28, 2024
Merged
5 tasks
OmarIthawi
OmarIthawi reviewed Feb 28, 2024
View reviewed changes
recommender/recommender.py
Comment on lines +982 to +989
@property
def i18n_service(self):
""" Obtains translation service """
i18n_service = self.runtime.service(self, "i18n")
if i18n_service:
return i18n_service
else:
return DummyTranslationService()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to know the goal of adding this function? Do we really need a DummyTranslationService?

If it's a copy from the LTI Consumer XBlock, I'm afraid we should remove it.

@OmarIthawi
Copy link
Member

@shadinaif please mark as draft.

@OmarIthawi
Copy link
Member

Closing to be merged with #77

@OmarIthawi OmarIthawi closed this Mar 17, 2024
@openedx-webhooks
Copy link

@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarIthawi OmarIthawi OmarIthawi left review comments

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadinaif @openedx-webhooks @OmarIthawi