Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Transifex calls for FC-0012 - OEP-58 #77

Merged

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Jan 31, 2024

Breaking change!


This PR depends on #81 and contains a cherry-pick from it until that one is merged


This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

  • Removes direct use of tx pull and tx push commands from the XBlock to let Open edX manage it.
  • Remove source and language translations from the repositories, hence no .po or .mo files will be committed into the repos.
  • Remove Transifex related Makefile targets and configuration files.
  • Use the OEP-58 JavaScript translations from the Open edX platform

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

## Keep this pull request as a draft to prevent an accidental merge. ##

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

@openedx-webhooks
Copy link

openedx-webhooks commented Jan 31, 2024

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 31, 2024
@shadinaif
Copy link
Contributor Author

for your review please @OmarIthawi

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 16, 2024
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 23, 2024
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.cleanup branch from 2f38302 to bd3e348 Compare February 28, 2024 08:26
@shadinaif shadinaif marked this pull request as ready for review March 13, 2024 07:30
@OmarIthawi OmarIthawi force-pushed the shadinaif/FC-0012-OEP-58.cleanup branch 5 times, most recently from 65fd161 to 7dd8452 Compare March 17, 2024 14:57
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadinaif I've pushed new changes but please update the README, and we need one more test on your devstack before moving this to ready for merge.

@OmarIthawi OmarIthawi force-pushed the shadinaif/FC-0012-OEP-58.cleanup branch from 7dd8452 to f1b740c Compare March 17, 2024 15:28
@OmarIthawi
Copy link
Member

Done @brian-smith-tcril!

@brian-smith-tcril brian-smith-tcril merged commit e5787b2 into openedx:master Mar 18, 2024
3 checks passed
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants