Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary use only dataset graph from platform #58

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Temporary use only dataset graph from platform #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dfee10
fix: Temporary use only dataset graph from platform
kovalch Apr 11, 2024
d12b1df
fix: Add comment todos comment
kovalch Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ckan_pkg_checker/checkers/shacl_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,14 @@ def check_package(self, pkg):
"""Check one data package"""
pkg_type = pkg.get("pkg_type", utils.DCAT)
dataset_graph = None
if pkg.get("source_url"):
dataset_graph = rdf_utils.get_dataset_graph_from_source(
pkg["source_url"], pkg["identifier"]
)
utils.log_and_echo_msg(
f"--> rdf graph for Dataset{pkg.get('name')} taken from harvest source"
)
# todo: Reenable checking harvest source graph once changes have been communicated to publishers
# if pkg.get("source_url"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put a comment like # todo: Reenable checking harvest source graph once changes have been communicated to publishers (or however you want to phrase it) in the code above this please? Otherwise we just have commented-out code here with no context, which is for readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, good idea :)
I will add it

# dataset_graph = rdf_utils.get_dataset_graph_from_source(
# pkg["source_url"], pkg["identifier"]
# )
# utils.log_and_echo_msg(
# f"--> rdf graph for Dataset{pkg.get('name')} taken from harvest source"
# )
if not dataset_graph:
pkg_dcat_serilization_url = utils.get_pkg_dcat_serialization_url(
self.siteurl, pkg["name"]
Expand Down
Loading