Temporary use only dataset graph from platform #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to communicate to the publisher first before using the graph from the harvester source, since there were many properties added to the shacl graph
bellisk
reviewed
Apr 11, 2024
| utils.log_and_echo_msg( | ||
| f"--> rdf graph for Dataset{pkg.get('name')} taken from harvest source" | ||
| ) | ||
| # if pkg.get("source_url"): |
There was a problem hiding this comment.
Could you put a comment like # todo: Reenable checking harvest source graph once changes have been communicated to publishers (or however you want to phrase it) in the code above this please? Otherwise we just have commented-out code here with no context, which is for readability.
There was a problem hiding this comment.
sure, good idea :)
I will add it
bellisk
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there were many properties added to the shacl graph,
we need to communicate to the publisher first before using the graph from the harvester source.