libct/cg: retry opening a cgroup file #4442
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frankly, I don't know if we should have this or not. |
|
I haven't checked in detail, but if it helps, crun is doing this: containers/crun#539. |
I think we already do this (treat |
kolyshkin
force-pushed
the
cg-retry
branch
2 times, most recently
from
255880c
to
66ac49d
Compare
From time to time we see unexpected errors (ENODEV or ENOENT) trying to write to a cgroup file. This is probably due to some races in the kernel. Let's implement a retry when we see ENOENT or ENODEV, but only if a directory exists. Note this can have a negative effect on performance when some cgroup features are disabled. Signed-off-by: Kir Kolyshkin <[email protected]>
|
Frankly, I don't know how to properly test this (other than merge this and see if the flakes are gone). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time we see unexpected errors (ENODEV or ENOENT) trying to write to a cgroup file. This is probably due to some races in the kernel.
Let's implement a retry when we see ENOENT or ENODEV, but only if a directory exists.
Note this can have a negative effect on performance when some cgroup features are disabled.
Fixes: #4136
Fixes: #3540
Fixes: #3351