Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: TestProcessEmptyCaps #4136

Open
cyphar opened this issue Dec 7, 2023 · 2 comments · May be fixed by #4442
Open

flaky test: TestProcessEmptyCaps #4136

cyphar opened this issue Dec 7, 2023 · 2 comments · May be fixed by #4442
Labels

Comments

@cyphar
Copy link
Member

cyphar commented Dec 7, 2023

I've started seeing this error in CI more often recently (in GHA CI runs). I suspect there's a race with the kernel creating the cgroup dentries. Maybe we should have some retry code? Idk.

=== RUN   TestProcessEmptyCaps
time="2023-12-07T04:19:25Z" level=warning msg="unable to get oom kill count" error="openat2 /sys/fs/cgroup/memory/test/integration/memory.oom_control: no such file or directory"
    exec_test.go:299: unexpected error: unable to start container process: unable to apply cgroup configuration: openat2 /sys/fs/cgroup/cpuset/test/integration/cpuset.mems: no such file or directory
--- FAIL: TestProcessEmptyCaps (0.13s)
@kolyshkin
Copy link
Contributor

Yes, I am seeing something like this, suspected a kernel race, and suggested a retry (#3351). Maybe we should do it :)

See also #3540.

@kolyshkin kolyshkin linked a pull request Oct 12, 2024 that will close this issue
@kolyshkin
Copy link
Contributor

This is mostly about cpuset.cpus and cpuset.mems for cgroup v1. We have an ugly mechanism of copying values from the parent cgroup during Apply, which no one has courage to remove. At least we don't have it for cgroup v2.

Anyway, here's my try: #4442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants