Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MACSEC SCI #1239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add MACSEC SCI #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion release/models/macsec/openconfig-macsec.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,18 @@ module openconfig-macsec {
"This module defines configuration and state data for
MACsec IEEE Std 802.1AE-2018.";

oc-ext:openconfig-version "1.1.1";
oc-ext:openconfig-version "1.2.0";
oc-ext:regexp-posix;
oc-ext:catalog-organization "openconfig";
oc-ext:origin "openconfig";

revision "2025-01-02" {
description
"Add include-sci to allow enable/disable of secure channel
identifiers.";
reference "1.2.0";
}

revision "2023-08-03" {
description
"Clarify in-cak and out-cak leaf descriptions.";
Expand Down Expand Up @@ -627,6 +634,12 @@ revision "2023-06-08" {
require an ICV";
}

leaf include-sci {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Cisco implementation, I assume that this is just not configurable to false -- but for the others this switch is needed? If so, LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would expect Cisco to accept a "true" value for this and reject a "false" whereas other implementations would accept either value.

type boolean;
description
"Generate and include a Secure Channel Identifier (SCI).";
}

leaf sak-rekey-interval {
type uint32 {
range "0 | 30..65535";
Expand Down
Loading