Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MACSEC SCI #1239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add MACSEC SCI #1239

wants to merge 1 commit into from

Conversation

dplore
Copy link
Member

@dplore dplore commented Jan 2, 2025 •
edited
Loading

Change Scope

  • Add a leaf to enable/disable MACSEC Secure Channel Identifier (SCI)
  • /macsec/mka/policies/policy/config/include-sci
  • This change is backwards compatible.

Platform Implementations

switch(config)# mac security
switch(config-mac-security)# profile TEST
switch(config-mac-security-profile-TEST)# sci

[edit security macsec connectivity-association connectivity-association-name]
user@host# set include-sci

@dplore dplore requested a review from a team as a code owner January 2, 2025 23:50
@OpenConfigBot
Copy link

No major YANG version changes in commit 8ae8a77

robshakir
robshakir approved these changes Jan 16, 2025
View reviewed changes
release/models/macsec/openconfig-macsec.yang
@@ -627,6 +634,12 @@ revision "2023-06-08" {
require an ICV";
}

leaf include-sci {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Cisco implementation, I assume that this is just not configurable to false -- but for the others this switch is needed? If so, LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would expect Cisco to accept a "true" value for this and reject a "false" whereas other implementations would accept either value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robshakir robshakir robshakir approved these changes

Assignees

@robshakir robshakir

Labels
non-breaking
Projects
OC Operator Review
Status: Ready to discuss
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplore @OpenConfigBot @robshakir