-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aft encapsulation-headers #1153
Conversation
No major YANG version changes in commit c47f0c8 |
Last-call for comments! This is planned to merge on Sep 26,2024. @rgwilton @nandanarista @earies @LimeHat for comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall hierarchy LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Specifically, approving that the existing ip-in-ip encap/decap structures will be deprecated in a future release. Re-iterating that we fully expect all vendors to support this until we've completed the migration.
… as a grouping instead of typedef, fix comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments
- do not add pop-top-level to encap-header/mpls container
- refactor mpls-label-stack to be a grouping instead of typdef
- update descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments!
LGTM.
Change Scope
Add AFT container representing next-hop encapsulation headers. A list of encap-headers is defined which is used to represent a stack of one or more packets added to any packet matching a next-hop.
Add containers for GRE, IP, UDP and MPLS encapsulation
Later we will deprecate the existing AFT encapsulation containers for ip-in-ip and gre and MPLS.
Changes to decapsulation are not in scope of this PR as the operational use cases inspiring this PR are met with with existing decapsulation leaves.
Use cases
Platform Implementations
Regarding MPLS in UDP encapsulation (which is the operational use case inspiring this change) is defined by RFC and supported by the following implementations.
Tree view
we are at: /network-instances/network-instance/afts/