Support margin time #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…margin info. This is required for BRCM PCIe switches. Signed-off-by: Sathish Sekar <[email protected]>
…ix/brcm_pcie_switch_settings Fixed the sequence to revert to normal settings before lane margin
Signed-off-by: Sathish Sekar <[email protected]>
…ix/handle-empty-string Replaced the string check to use boolean instead of None
Signed-off-by: Sathish Sekar <[email protected]>
|
hey @churchmice; instructions on how to fix the DCO check are here https://github.com/opencomputeproject/ocp-diag-pci_lmt/pull/21/checks but first you'll need to rebase your branch on dev; it looks like you started your fork from the
|
|
hi, @mimir-d ， thanks for the detailed instruction. |
|
that's ok, everyone starts from somewhere. let me know if the above steps dont work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following features are enhanced :
Per pcie spec 4.2.18.4
"Software should allow margining to run for at least 10^8 bits margined by the Receiver under test before
switching to the next margin step location (unless the error limit is exceeded)."
The current LMT code does not consider this and the margin is done immediately.
A new -m margin_time option is added to let the lane execute at least margin_time seconds.
When a margin command is sent to the device, it is possible the device will need some time to prepare the margin, in other words, we need to check the step_margin_execution_status is 10 ( margin in progress ) before concluding the margin is in progress.
We run the original code on our products and find the margin results are inconsistent：
After the two fixes, the margin result is consistent.