Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semantic definitions for Oracle Database #1911

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
23 changes: 23 additions & 0 deletions .chloggen/add_oracledb_semconv.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Use this changelog template to create an entry for release notes.
#
# If your change doesn't affect end users you should instead start
# your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: new_component

# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
component: db

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Adding semnatic conventions for `oracledb` instrumentations.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
# The values here must be integers.
issues: [2612]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
Oracle Database semantic conventions.
1 change: 1 addition & 0 deletions docs/attributes-registry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ Currently, the following namespaces exist:
- [NodeJS](nodejs.md)
- [OCI](oci.md)
- [OpenTracing](opentracing.md)
- [OracleDatabase](oracledb.md)
- [OS](os.md)
- [OTel](otel.md)
- [Peer](peer.md)
Expand Down
20 changes: 20 additions & 0 deletions docs/attributes-registry/oracledb.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
<!-- see templates/registry/markdown/attribute_namespace.md.j2 -->

# Oracle Database

## Oracle Database Attributes

This section defines attributes for Oracle Database.

| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| <a id="oracledb-pool-min" href="#oracledb-pool-min">`oracledb.pool.min`</a> | int | This read-only property is a number which specifies the minimum number of connections a connection pool maintains, even when there is no activity to the target database. | `0`; `3`; `4` | ![Development](https://img.shields.io/badge/-development-blue) |
| <a id="oracledb-pool-max" href="#oracledb-pool-min">`oracledb.pool.max`</a> | int | This read-only property is a number which specifies the maximum number of connections that can be open in the connection pool. | `2`; `30`; `70` | ![Development](https://img.shields.io/badge/-development-blue) |
| <a id="oracledb-pool-incr" href="#oracledb-pool-min">`oracledb.pool.incr`</a> | int | This read-only property is a number which specifies the number of connections that are opened whenever a connection request exceeds the number of currently open connections. | `2`; `10`; `15` | ![Development](https://img.shields.io/badge/-development-blue) |
| <a id="oracledb-bind-values" href="#oracledb-bind-values">`oracledb.bind.values`</a> | string[] | Array of bind values passed to parameterized queries. | `['43', 'scott', 'true'` | [Development](https://img.shields.io/badge/-development-blue) |
| <a id="oracledb-instance" href="#oracledb-instance">`oracledb.instance`</a> | string | Oracle Database Instance. | `ORCL1`; `ORCL2`; | [Development](https://img.shields.io/badge/-development-blue) |
| <a id="oracledb-pdbname" href="#oracledb-pdbname">`oracledb.pdbname`</a> | string | Pluggable Database (PDB) name in a Multitenant Container Database (CDB) environment. | `PDB1`; `PDB2`; | [Development](https://img.shields.io/badge/-development-blue) |
| <a id="oracledb-implicit_release" href="#oracledb-implicit_release">`oracledb.implicit_release`</a> | boolean | Indicates if the internal connection is released back to pool or not after executing a query. | `true` | [Development](https://img.shields.io/badge/-development-blue) |

---
1 change: 1 addition & 0 deletions docs/database/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Technology specific semantic conventions are defined for the following databases
* [HBase](hbase.md): Semantic Conventions for *HBase*.
* [MongoDB](mongodb.md): Semantic Conventions for *MongoDB*.
* [Microsoft SQL Server](mssql.md): Semantic Conventions for *Microsoft SQL Server*.
* [Oracle Database](oracledb.md): Semantic Conventions for *Oracle Database*.
* [Redis](redis.md): Semantic Conventions for *Redis*.
* [SQL](sql.md): Semantic Conventions for *SQL* databases.

Expand Down
115 changes: 115 additions & 0 deletions docs/database/oracledb.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
<!--- Hugo front matter used to generate the website version of this page:
linkTitle: Oracle Database
--->

# Semantic conventions for Oracle Database

**Status**: [Release Candidate][DocumentStatus]

<!-- toc -->

- [Spans](#spans)
- [Metrics](#metrics)

<!-- tocstop -->

The Semantic Conventions for *Oracle Database* extend and override the [Database Semantic Conventions](README.md).

## Spans

Spans representing calls to Oracle Database adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md).

`db.system.name` MUST be set to `"oracle.db"` and SHOULD be provided **at span creation time**.

The following table outlines the span attributes applicable to Oracle Database.

<!-- semconv span.db.oracledb.client -->
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
<!-- see templates/registry/markdown/snippet.md.j2 -->
<!-- prettier-ignore-start -->
<!-- markdownlint-capture -->
<!-- markdownlint-disable -->

| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`db.namespace`](/docs/attributes-registry/db.md) | string | The service name associated with the connection. [1] | `db_high.adb.oraclecloud.com`; `db_low.adb.oraclecloud.com` | `Conditionally Required` If available without an additional network call. | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`db.response.status_code`](/docs/attributes-registry/db.md) | string | [Oracle Database error number](https://docs.oracle.com/en/error-help/db/) recorded as a string. | `ORA-02813`; `ORA-024459` | `Conditionally Required` If response has ended with warning or an error. | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`error.type`](/docs/attributes-registry/error.md) | string | Describes a class of error the operation ended with. [2] | `timeout`; `java.net.UnknownHostException`; `server_certificate_invalid`; `500` | `Conditionally Required` If and only if the operation failed. | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`server.port`](/docs/attributes-registry/server.md) | int | Server port number. [3] | `1521`; `1522`; | `Conditionally Required` [4] | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
| [`db.operation.batch.size`](/docs/attributes-registry/db.md) | int | The number of queries included in a batch operation. [5] | `2`; `3`; `4` | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`db.query.summary`](/docs/attributes-registry/db.md) | string | Low cardinality representation of a database query text. [6] | `SELECT wuser_table`; `INSERT shipping_details SELECT orders`; `get user by id` | `Recommended` [7] | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`db.query.text`](/docs/attributes-registry/db.md) | string | The database query being executed. [8] | `VARIABLE mykey VARCHAR2(50) = 'some_val'`; `SELECT * FROM wuser_table where username = :mykey`; | `Recommended` [9] | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`db.response.returned_rows`](/docs/attributes-registry/db.md) | int | Number of rows returned by the operation. | `10`; `30`; `1000` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`server.address`](/docs/attributes-registry/server.md) | string | Name of the database host. [10] | `example.com`; `10.1.2.80`; | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
| [`db.operation.parameter.<key>`](/docs/attributes-registry/db.md) | string | A database operation parameter, with `<key>` being the parameter name, and the attribute value being a string representation of the parameter value. [11] | `someval`; `55` | `Opt-In` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.pool.min`](/docs/attributes-registry/oracledb.md) | int | This read-only property is a number which specifies the minimum number of connections a connection pool maintains, even when there is no activity to the target database. | `0`; `3`; `4` | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.pool.max`](/docs/attributes-registry/oracledb.md) | int | This read-only property is a number which specifies the maximum number of connections that can be open in the connection pool. | `2`; `30`; `70` | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.pool.incr`](/docs/attributes-registry/oracledb.md) | int | This read-only property is a number which specifies the number of connections that are opened whenever a connection request exceeds the number of currently open connections. | `2`; `10`; `15` | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.bind.values`](/docs/attributes-registry/oracledb.md) | string[] | Array of bind values passed to parameterized queries. | `['43', 'scott', 'true'` | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.instance`](/docs/attributes-registry/oracledb.md) | string | Oracle Database Instance. | `ORCL1`; `ORCL2`; | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.pdbname`](/docs/attributes-registry/oracledb.md) | string | Pluggable Database (PDB) name in a Multitenant Container Database (CDB) environment. | `PDB1`; `PDB2`; | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |
| [`oracledb.implicit_release`](/docs/attributes-registry/oracledb.md) | boolean | Indicates if the internal connection is released back to pool or not after executing a query. | `true` | `Recommended` | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) |

**[1] `db.namespace`:** `db.namespace` SHOULD be set to the service name used to connect to the database.

Instrumentation SHOULD document if `db.namespace` reflects the service name provided when the connection was established.

It is RECOMMENDED to capture the value as provided by the application without attempting to do any case normalization.

**[2] `error.type`:** The `error.type` SHOULD match the `db.response.status_code` returned by the database or the client library, or the canonical name of exception that occurred.
When using canonical exception type name, instrumentation SHOULD do the best effort to report the most relevant type. For example, if the original exception is wrapped into a generic one, the original exception SHOULD be preferred.
Instrumentations SHOULD document how `error.type` is populated.

**[3] `server.port`:** When observed from the client side, and when communicating through an intermediary, `server.port` SHOULD represent the server port behind any intermediaries, for example proxies, if it's available.

**[4] `server.port`:** If using a port other than the default port for this DBMS and if `server.address` is set.

**[5] `db.operation.batch.size`:** Operations are only considered batches when they contain two or more operations, and so `db.operation.batch.size` SHOULD never be `1`.

**[6] `db.query.summary`:** `db.query.summary` provides static summary of the query text. It describes a class of database queries and is useful as a grouping key, especially when analyzing telemetry for database calls involving complex queries.
A Summary may be available to the instrumentation through instrumentation hooks or other means. If it is not available, instrumentations that support query parsing SHOULD generate a summary following [Generating query summary](../database/database-spans.md#generating-a-summary-of-the-query-text) section.

**[7] `db.query.summary`:** if readily available or if instrumentation supports query summarization.

**[8] `db.query.text`:** For sanitization see [Sanitization of `db.query.text`](../database/database-spans.md#sanitization-of-dbquerytext).
For batch operations, if the individual operations are known to have the same query text then that query text SHOULD be used, otherwise all of the individual query texts SHOULD be concatenated with separator `; ` or some other database system specific separator if more applicable.
Even though parameterized query text can potentially have sensitive data, by using a parameterized query the user is giving a strong signal that any sensitive data will be passed as parameter values, and the benefit to observability of capturing the static part of the query text by default outweighs the risk.

**[9] `db.query.text`:** Non-parameterized query text SHOULD NOT be collected by default unless explicitly configured and sanitized to exclude sensitive data, e.g. by redacting all literal values present in the query text. See [Sanitization of `db.query.text`](../database/database-spans.md#sanitization-of-dbquerytext).
Parameterized query text MUST also NOT be collected by default unless explicitly configured. The query parameter values themselves are opt-in, see [`db.operation.parameter.<key>`](../attributes-registry/db.md).

**[10] `server.address`:** When observed from the client side, and when communicating through an intermediary, `server.address` SHOULD represent the server address behind any intermediaries, for example proxies, if it's available.

**[11] `db.operation.parameter`:** If a parameter has no name and instead is referenced only by index, then `<key>` SHOULD be the 0-based index.
If `db.query.text` is also captured, then `db.operation.parameter.<key>` SHOULD match up with the parameterized placeholders present in `db.query.text`.

The following attributes can be important for making sampling decisions
and SHOULD be provided **at span creation time** (if provided at all):

* [`db.namespace`](/docs/attributes-registry/db.md)
* [`db.query.summary`](/docs/attributes-registry/db.md)
* [`db.query.text`](/docs/attributes-registry/db.md)
* [`server.address`](/docs/attributes-registry/server.md)
* [`server.port`](/docs/attributes-registry/server.md)

---

`error.type` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.

| Value | Description | Stability |
|---|---|---|
| `_OTHER` | A fallback error value to be used when the instrumentation doesn't define a custom value. | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |

<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->
<!-- END AUTOGENERATED TEXT -->
<!-- endsemconv -->

## Metrics

Oracle Database driver instrumentation SHOULD collect metrics according to the general
[Semantic Conventions for Database Client Metrics](database-metrics.md).

`db.system.name` MUST be set to `"oracle.db"`.

[DocumentStatus]: https://opentelemetry.io/docs/specs/otel/document-status
23 changes: 23 additions & 0 deletions model/database/spans.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -810,3 +810,26 @@ groups:
- ref: azure.cosmosdb.operation.contacted_regions
requirement_level:
conditionally_required: If available.
- id: span.db.oracledb.client
type: span
stability: experimental
extends: span.db.sql.client
span_kind: client
brief: >
Attributes for Oracle Database
attributes:
- ref: db.namespace
sampling_relevant: true
brief: The service name associated with the connection.
note: |
Instrumentation SHOULD document if `db.namespace` reflects the service name provided when the connection was established.

It is RECOMMENDED to capture the value as provided by the application without attempting to do any case normalization.
examples: ["db_high.adb.oraclecloud.com", "db_low.adb.oraclecloud.com"]
- ref: db.response.status_code
brief: >
[Oracle Database error number](https://docs.oracle.com/en/error-help/db/) recorded as a string.
note: >
Oracle Database error codes are vendor specific error codes and don't follow [SQLSTATE](https://wikipedia.org/wiki/SQLSTATE)
conventions. All Oracle Database error codes SHOULD be considered errors.
examples: ["ORA-02813", "ORA-02613"]
16 changes: 16 additions & 0 deletions schema-next.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,22 @@ versions:
- rename_metrics:
k8s.replication_controller.desired_pods: k8s.replicationcontroller.desired_pods
k8s.replication_controller.available_pods: k8s.replicationcontroller.available_pods
all:
changes:
# https://github.com/open-telemetry/semantic-conventions/pull/TODO
# add semantic conventions for Oracle Database
- add_attributes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file supports an add_attributes field.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have removed it now. I have added oracle specific attributes for yaml format , model/oracledb/registry.yaml Is this ok?

db.system.name
db.namespace
db.response.status_code
error.type
server.port
db.operation.batch.size
db.query.summary
db.query.text
db.response.returned_rows
server.address
db.operation.parameter.<key>
1.30.0:
all:
changes:
Expand Down