Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semantic definitions for Oracle Database #1911

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sudarshan12s
Copy link

Fixes #

Changes

Add semantic conventions for Oracle Database.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

sudarshan12s and others added 2 commits February 17, 2025 12:51
* - Add semantic conventions for oracle database
schema-next.yaml Outdated
changes:
# https://github.com/open-telemetry/semantic-conventions/pull/TODO
# add semantic conventions for Oracle Database
- add_attributes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file supports an add_attributes field.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have removed it now. I have added oracle specific attributes for yaml format , model/oracledb/registry.yaml Is this ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants