-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Semantic definitions for Oracle Database #1911
base: main
Are you sure you want to change the base?
Conversation
* - Add semantic conventions for oracle database
schema-next.yaml
Outdated
changes: | ||
# https://github.com/open-telemetry/semantic-conventions/pull/TODO | ||
# add semantic conventions for Oracle Database | ||
- add_attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file supports an add_attributes field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have removed it now. I have added oracle specific attributes for yaml format , model/oracledb/registry.yaml
Is this ok?
(`db.operation.parameter.<key>`) in generic way.
Fixes #
Changes
Add semantic conventions for Oracle Database.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]