Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-express): Use router path in router span names #2319

Merged

Merge branch 'main' into nested-express-routes

599ca96
Select commit
Loading
Failed to load commit list.
Merged

feat(instrumentation-express): Use router path in router span names #2319

Merge branch 'main' into nested-express-routes
599ca96
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2024 in 1s

92.21% (+1.23%) compared to dfb2dff

View this Pull Request on Codecov

92.21% (+1.23%) compared to dfb2dff

Details

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.21%. Comparing base (dfb2dff) to head (599ca96).
Report is 225 commits behind head on main.

Files with missing lines Patch % Lines
...opentelemetry-instrumentation-express/src/utils.ts 35.29% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
+ Coverage   90.97%   92.21%   +1.23%     
==========================================
  Files         146       87      -59     
  Lines        7492     4277    -3215     
  Branches     1502      830     -672     
==========================================
- Hits         6816     3944    -2872     
+ Misses        676      333     -343     
Files with missing lines Coverage Δ
...try-instrumentation-express/src/instrumentation.ts 70.21% <100.00%> (-29.79%) ⬇️
...etry-instrumentation-express/src/internal-types.ts 100.00% <ø> (ø)
...opentelemetry-instrumentation-express/src/utils.ts 55.38% <35.29%> (-42.24%) ⬇️

... and 104 files with indirect coverage changes