Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-express): Use router path in router span names #2319

Merged
merged 9 commits into from
Sep 17, 2024

Merge branch 'main' into nested-express-routes

599ca96
Select commit
Loading
Failed to load commit list.
Merged

feat(instrumentation-express): Use router path in router span names #2319

Merge branch 'main' into nested-express-routes
599ca96
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 2, 2024 in 0s

38.88% of diff hit (target 80.00%)

View this Pull Request on Codecov

38.88% of diff hit (target 80.00%)

Annotations

Check warning on line 54 in plugins/node/opentelemetry-instrumentation-express/src/utils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/node/opentelemetry-instrumentation-express/src/utils.ts#L54 

Added line #L54 was not covered by tests

Check warning on line 57 in plugins/node/opentelemetry-instrumentation-express/src/utils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/node/opentelemetry-instrumentation-express/src/utils.ts#L56-L57 

Added lines #L56 - L57 were not covered by tests

Check warning on line 61 in plugins/node/opentelemetry-instrumentation-express/src/utils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/node/opentelemetry-instrumentation-express/src/utils.ts#L60-L61 

Added lines #L60 - L61 were not covered by tests

Check warning on line 64 in plugins/node/opentelemetry-instrumentation-express/src/utils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/node/opentelemetry-instrumentation-express/src/utils.ts#L64 

Added line #L64 was not covered by tests

Check warning on line 85 in plugins/node/opentelemetry-instrumentation-express/src/utils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/node/opentelemetry-instrumentation-express/src/utils.ts#L82-L85 

Added lines #L82 - L85 were not covered by tests

Check warning on line 193 in plugins/node/opentelemetry-instrumentation-express/src/utils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/node/opentelemetry-instrumentation-express/src/utils.ts#L193 

Added line #L193 was not covered by tests
View more details on Codecov