Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add capacity information when applicable to dynamodb spans #1365

Merged
merged 7 commits into from
Aug 12, 2023

Conversation

nordfjord
Copy link
Contributor

Which problem is this PR solving?

  • DynamoDB spans should contain consumed capacity information (source)
  • The current implementation only includes it for "BatchGetItems" requests

Short description of the changes

  • Removes the check for command type
  • If capacity information was returned it is added to the span
  • If the returned capacity information is not an array it's turned into a singleton array

@nordfjord nordfjord requested a review from a team January 29, 2023 17:49
@nordfjord nordfjord force-pushed the aws-dynamo-capacity branch 2 times, most recently from 00afafa to 5739917 Compare January 29, 2023 17:51
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #1365 (e89d7ad) into main (704f76f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1365   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files         139      139           
  Lines        7124     7124           
  Branches     1432     1432           
=======================================
  Hits         6540     6540           
  Misses        584      584           
Files Changed Coverage Δ
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <100.00%> (ø)

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
please add tests for this

@haddasbronfman
Copy link
Member

Hi @nordfjord, are you still interested in working on this PR?

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 1, 2023
@nordfjord
Copy link
Contributor Author

Hi @nordfjord, are you still interested in working on this PR?

Hey, sorry for my slow replies here. I'll have some time this week to add the requested tests!

@haddasbronfman
Copy link
Member

great. thanks!

@nordfjord nordfjord force-pushed the aws-dynamo-capacity branch from 073dbbd to 2d2d098 Compare May 5, 2023 03:24
@nordfjord nordfjord force-pushed the aws-dynamo-capacity branch from 2d2d098 to 8ad87fc Compare May 5, 2023 03:26
@nordfjord
Copy link
Contributor Author

Hey y'all, sorry again for the tardiness, I've added two test cases now to cover the functionality 🎉

@pichlermarc
Copy link
Member

The failing TAV script here is related to #1477
cc @carolabadeer I think this PR is still waiting for an owner review 🙂

Copy link
Contributor

@carolabadeer carolabadeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for making this change!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 7, 2023
@carolabadeer
Copy link
Contributor

carolabadeer commented Aug 10, 2023

Any blocker to merging this change? I believe the TAV workflow failure is unrelated to this change, it is documented in #1477 which is being worked on

@blumamir
Copy link
Member

Any blocker to merging this change? I believe the TAV workflow failure is unrelated to this change, it is documented in #1477 which is being worked on

LGTM.

Let's merge and fix the tav issue mentioned in #1477 run in a different PR.

@blumamir blumamir merged commit ad94c5c into open-telemetry:main Aug 12, 2023
@dyladan dyladan mentioned this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants