-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add capacity information when applicable to dynamodb spans #1365
Conversation
00afafa
to
5739917
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 139 139
Lines 7124 7124
Branches 1432 1432
=======================================
Hits 6540 6540
Misses 584 584
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
please add tests for this
Hi @nordfjord, are you still interested in working on this PR? |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Hey, sorry for my slow replies here. I'll have some time this week to add the requested tests! |
great. thanks! |
073dbbd
to
2d2d098
Compare
2d2d098
to
8ad87fc
Compare
Hey y'all, sorry again for the tardiness, I've added two test cases now to cover the functionality 🎉 |
plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/dynamodb.ts
Show resolved
Hide resolved
The failing TAV script here is related to #1477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for making this change!
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Any blocker to merging this change? I believe the TAV workflow failure is unrelated to this change, it is documented in #1477 which is being worked on |
Which problem is this PR solving?
Short description of the changes