feat: Add capacity information when applicable to dynamodb spans

open-telemetry · Jan 29, 2023 · 5739917 · 5739917
1 parent aae03f2
commit 5739917
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/dynamodb.ts b/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/dynamodb.ts
@@ -58,20 +58,20 @@ export class DynamodbServiceExtension implements ServiceExtension {
   responseHook(
     response: NormalizedResponse,
     span: Span,
-    tracer: Tracer,
-    config: AwsSdkInstrumentationConfig
+    _tracer: Tracer,
+    _config: AwsSdkInstrumentationConfig
   ) {
-    const operation = response.request.commandName;
-
-    if (operation === 'BatchGetItem') {
-      if (Array.isArray(response.data?.ConsumedCapacity)) {
-        span.setAttribute(
-          SemanticAttributes.AWS_DYNAMODB_CONSUMED_CAPACITY,
-          response.data.ConsumedCapacity.map(
-            (x: { [DictionaryKey: string]: any }) => JSON.stringify(x)
-          )
-        );
-      }
+    if ("ConsumedCapacity" in response.data) {
+      span.setAttribute(
+        SemanticAttributes.AWS_DYNAMODB_CONSUMED_CAPACITY,
+        toArray(response.data.ConsumedCapacity).map(
+          (x: { [DictionaryKey: string]: any }) => JSON.stringify(x)
+        )
+      );
     }
   }
 }
+
+function toArray<T>(values: T | T[]): T[] {
+  return Array.isArray(values) ? values : [values];
+}