Remove -alpha artifacts from runtime classpath of stable components #6944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6944 +/- ##
============================================
- Coverage 89.99% 89.94% -0.06%
- Complexity 6596 6634 +38
============================================
Files 729 745 +16
Lines 19858 20010 +152
Branches 1955 1962 +7
============================================
+ Hits 17871 17997 +126
- Misses 1389 1417 +28
+ Partials 598 596 -2 ☔ View full report in Codecov by Sentry. |
jack-berg
commented
Dec 11, 2024
jack-berg
commented
Dec 11, 2024
jack-berg
commented
Dec 11, 2024
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkMeter.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Dec 11, 2024
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkTracer.java
Outdated
Show resolved
Hide resolved
jack-berg
commented
Dec 19, 2024
| @@ -23,4 +42,63 @@ void incubatingApiIsLoadedViaReflection() { | |||
| assertThat(MeterProvider.noop().get("test").counterBuilder("test")) | |||
| .isInstanceOf(ExtendedLongCounterBuilder.class); | |||
| } | |||
|
|
|||
| @Test | |||
| void incubatingLogSdk() { | |||
There was a problem hiding this comment.
Not sure why, but these new graal nativeTest woked without any additional reflect-config.json entries, despite new reflective access in the SDK via Class.forName. 🤔
trask
approved these changes
Jan 12, 2025
.../src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ExtendedSdkLongGauge.java
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ExtendedSdkLongHistogram.java
Show resolved
Hide resolved
| @@ -11,6 +11,7 @@ | |||
| import static io.opentelemetry.sdk.trace.internal.TracerConfig.defaultConfig; | |||
| import static io.opentelemetry.sdk.trace.internal.TracerConfig.disabled; | |||
| import static io.opentelemetry.sdk.trace.internal.TracerConfig.enabled; | |||
| import static org.assertj.core.api.Assertions.assertThat; | |||
There was a problem hiding this comment.
Suggested change
| import static org.assertj.core.api.Assertions.assertThat; |
There was a problem hiding this comment.
Why does the build pass despite this unused import? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6970.
Remove
-alphaartifacts (especiallyopentelemetry-api-incubator) from the runtime classpath of stable components.Approach is:
implementationtocompileOnlydependencies-alphaartifact is present on classpath (i.e. provided by the user) and toggle behavior based on whether it is or isnt-alphaartifacts are not provided by user, make sure main test suite runs without-alphaartifacts.-alphaartifacts are present, introduce new test suite including the-alphaartifacts, and test the impacted behaviorThis is related to a possible adjustment of our versioning guidelines. If we went in this direction, a user adding only stable dependencies could always run
./gradlew dependenciesand will not see any-alphaartifacts on the runtime classpath.