Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event name as an incubating feature #7012

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

trask
Copy link
Member

@trask trask commented Jan 12, 2025

No description provided.

@trask trask force-pushed the event-name branch 4 times, most recently from d65288c to fa6196b Compare January 13, 2025 22:31
@trask trask force-pushed the event-name branch 5 times, most recently from fb22190 to 6fadc54 Compare January 13, 2025 23:18
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 68.62745% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (d56bdf5) to head (b1ee53b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...sting/logs/internal/TestExtendedLogRecordData.java 53.57% 13 Missing ⚠️
...elemetry/sdk/logs/ExtendedSdkLogRecordBuilder.java 0.00% 2 Missing ⚠️
...etry/api/incubator/logs/ExtendedDefaultLogger.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7012      +/-   ##
============================================
- Coverage     89.95%   89.89%   -0.06%     
- Complexity     6635     6643       +8     
============================================
  Files           745      746       +1     
  Lines         20010    20059      +49     
  Branches       1962     1968       +6     
============================================
+ Hits          17999    18032      +33     
- Misses         1415     1431      +16     
  Partials        596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask trask changed the title [work in progress] Add setEventName to ExtendedLogRecordBuilder Add event name as an incubating feature Jan 13, 2025
@trask trask marked this pull request as ready for review January 13, 2025 23:42
@trask trask requested a review from a team as a code owner January 13, 2025 23:42
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments, but looks good.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onward! 🚀

@jack-berg jack-berg merged commit 97410cb into open-telemetry:main Jan 16, 2025
24 of 25 checks passed
@trask trask deleted the event-name branch January 16, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants