-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event name as an incubating feature #7012
Conversation
d65288c
to
fa6196b
Compare
...ers/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/LogMarshaler.java
Show resolved
Hide resolved
fb22190
to
6fadc54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7012 +/- ##
============================================
- Coverage 89.95% 89.89% -0.06%
- Complexity 6635 6643 +8
============================================
Files 745 746 +1
Lines 20010 20059 +49
Branches 1962 1968 +6
============================================
+ Hits 17999 18032 +33
- Misses 1415 1431 +16
Partials 596 596 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor comments, but looks good.
api/incubator/src/main/java/io/opentelemetry/api/incubator/logs/ExtendedLogRecordBuilder.java
Show resolved
Hide resolved
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLogRecordData.java
Outdated
Show resolved
Hide resolved
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/data/internal/ExtendedLogRecordData.java
Outdated
Show resolved
Hide resolved
…ata.java Co-authored-by: jack-berg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onward! 🚀
No description provided.