Add linter rules to prevent uses of the SDK in bridges and instrumentations #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
the
Skip Changelog
dmathieu
requested review from
MadVikingGod,
a team and
dashpole
as code owners
dashpole
reviewed
Sep 23, 2024
dmathieu
force-pushed
the
instrumentation-no-sdk
branch
from
b02734c to
52b38b6
Compare
dashpole
approved these changes
Sep 23, 2024
dashpole
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridges and instrumentations shouldn't rely on the SDK (except in tests located in a test submodule).
So this adds a linter rule which enforces it.
I have fixes the obvious failures. For anything that wasn't trivial, I've set exceptions, as I don't want this PR to become huge.