allow sdk for prometheus and runtime at the golangci level

.golangci.yml

@@ -78,6 +78,8 @@ linters-settings:
       no-sdk-instrumentation:
         files:
           - "**/*/{bridges,instrumentation}/**/*.go"
+          - "!**/*/bridges/prometheus/*.go" # prometheus bridge is meant to use the SDK
+          - "!**/*/instrumentation/runtime/*.go" # runtime instrumentation is meant to use the SDK
           - "!**/*test/*.go"
           - "!**/*test/**/*.go"
           - "!**/*example/*.go"

bridges/prometheus/example_test.go

@@ -5,7 +5,7 @@ package prometheus_test
 
 import (
 	"go.opentelemetry.io/contrib/bridges/prometheus"
-	"go.opentelemetry.io/otel/sdk/metric" //nolint:depguard
+	"go.opentelemetry.io/otel/sdk/metric"
 )
 
 func ExampleNewMetricProducer() {

bridges/prometheus/producer.go

@@ -16,9 +16,9 @@ import (
 
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/sdk/instrumentation"   //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric"            //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric/metricdata" //nolint:depguard
+	"go.opentelemetry.io/otel/sdk/instrumentation"
+	"go.opentelemetry.io/otel/sdk/metric"
+	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 )
 
 const (

bridges/prometheus/producer_test.go

@@ -13,9 +13,9 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/sdk/instrumentation"                  //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric/metricdata"                //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest" //nolint:depguard
+	"go.opentelemetry.io/otel/sdk/instrumentation"
+	"go.opentelemetry.io/otel/sdk/metric/metricdata"
+	"go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest"
 )
 
 const (

instrumentation/runtime/example_test.go

@@ -10,7 +10,7 @@ import (
 
 	"go.opentelemetry.io/contrib/instrumentation/runtime"
 	"go.opentelemetry.io/otel"
-	"go.opentelemetry.io/otel/sdk/metric" //nolint:depguard
+	"go.opentelemetry.io/otel/sdk/metric"
 )
 
 func Example() {

instrumentation/runtime/producer.go

@@ -12,9 +12,9 @@ import (
 	"time"
 
 	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/sdk/instrumentation"   //nolint:depguard // We rely on instrumentation.Scope.
-	"go.opentelemetry.io/otel/sdk/metric"            //nolint:depguard // We rely on metric.Producer.
-	"go.opentelemetry.io/otel/sdk/metric/metricdata" // nolint:depguard // We rely on metricdata.
+	"go.opentelemetry.io/otel/sdk/instrumentation"
+	"go.opentelemetry.io/otel/sdk/metric"
+	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 )
 
 var startTime time.Time

instrumentation/runtime/test/producer_test.go → instrumentation/runtime/producer_test.go

@@ -1,7 +1,7 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
-package test
+package runtime // import "go.opentelemetry.io/contrib/instrumentation/runtime"
 
 import (
 	"context"
@@ -10,15 +10,14 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
-	"go.opentelemetry.io/contrib/instrumentation/runtime"
 	"go.opentelemetry.io/otel/sdk/instrumentation"
 	"go.opentelemetry.io/otel/sdk/metric"
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 	"go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest"
 )
 
 func TestNewProducer(t *testing.T) {
-	reader := metric.NewManualReader(metric.WithProducer(runtime.NewProducer()))
+	reader := metric.NewManualReader(metric.WithProducer(NewProducer()))
 	_ = metric.NewMeterProvider(metric.WithReader(reader))
 	rm := metricdata.ResourceMetrics{}
 	err := reader.Collect(context.Background(), &rm)
@@ -29,7 +28,7 @@ func TestNewProducer(t *testing.T) {
 	expectedScopeMetric := metricdata.ScopeMetrics{
 		Scope: instrumentation.Scope{
 			Name:    "go.opentelemetry.io/contrib/instrumentation/runtime",
-			Version: runtime.Version(),
+			Version: Version(),
 		},
 		Metrics: []metricdata.Metrics{
 			{

instrumentation/runtime/runtime_test.go

@@ -15,10 +15,10 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/sdk/instrumentation"                  //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric"                           //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric/metricdata"                //nolint:depguard
-	"go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest" //nolint:depguard
+	"go.opentelemetry.io/otel/sdk/instrumentation"
+	"go.opentelemetry.io/otel/sdk/metric"
+	"go.opentelemetry.io/otel/sdk/metric/metricdata"
+	"go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest"
 )
 
 func TestRefreshGoCollector(t *testing.T) {