processmanager: Fix process exit regression (#337) #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
approved these changes
Feb 3, 2025
This fixes an issue introduced with dd4c52b.
florianl
reviewed
Feb 3, 2025
christos68k
force-pushed
the
ck/fix-exit
branch
from
0bd8d17 to
7f3bafe
Compare
florianl
reviewed
Feb 3, 2025
rockdaboot
reviewed
Feb 4, 2025
processmanager/processinfo.go
Outdated
| // ProcessPIDExit may be called multiple times in short succession | ||
| // for the same PID, don't update exitKTime if we've previously recorded it. | ||
| if _, pidExitProcessed := pm.exitEvents[pid]; !pidExitProcessed { | ||
| if _, pidExitProcessed = pm.exitEvents[pid]; !pidExitProcessed { |
There was a problem hiding this comment.
Code coverage report shows that our unit tests doesn't cover this block of code. That needs to be improved.
Co-authored-by: Florian Lehner <[email protected]>
florianl
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue introduced with dd4c52b.