Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pidPageToMappingInfo keys #337

Closed
christos68k opened this issue Feb 3, 2025 · 1 comment · Fixed by #338
Closed

Missing pidPageToMappingInfo keys #337

christos68k opened this issue Feb 3, 2025 · 1 comment · Fixed by #338
Assignees
Labels
bug Something isn't working

Comments

@christos68k
Copy link
Member

christos68k commented Feb 3, 2025

Summary

Noticed a lot of errors with the current master:

ERRO[0300] failed to delete dummy prefix for PID 23385: batch delete: key does not exist 
ERRO[0300] failed to delete dummy prefix for PID 24074: batch delete: key does not exist 
ERRO[0300] failed to delete dummy prefix for PID 24148: batch delete: key does not exist 
ERRO[0300] failed to delete dummy prefix for PID 26289: batch delete: key does not exist 
ERRO[0300] failed to delete dummy prefix for PID 26931: batch delete: key does not exist 
ERRO[0300] failed to delete dummy prefix for PID 24314: batch delete: key does not exist 

I tracked the issue down to dd4c52b (PR: #325) so it seems that the refactoring we did in #325
did not maintain previous semantics / introduced a race.

For more context see this thread.

To reproduce, execute a workload that combines both CPU usage and spawns a lot of processes (e.g. build the agent)

@christos68k christos68k added the bug Something isn't working label Feb 3, 2025
@christos68k christos68k self-assigned this Feb 3, 2025
@christos68k
Copy link
Member Author

The easy fix is to partially revert #325 and restore the ProcessPIDExit logic to f094776. I'll dig some more to find out the root cause.

christos68k added a commit that referenced this issue Feb 3, 2025
This fixes an issue introduced with dd4c52b.
@christos68k christos68k linked a pull request Feb 3, 2025 that will close this issue
christos68k added a commit that referenced this issue Feb 3, 2025
This fixes an issue introduced with dd4c52b.
rockdaboot pushed a commit that referenced this issue Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant