Add devcontainer #3123
Add devcontainer #3123
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 88.16% 88.13% -0.03%
==========================================
Files 198 198
Lines 6224 6224
==========================================
- Hits 5487 5485 -2
- Misses 737 739 +2 |
| Before getting started, ensure you have the following installed: | ||
|
|
||
| * **Docker**: DevContainers require Docker for containerization. | ||
| * **Visual Studio Code (VSCode)** with the **Remote - Containers** extension. |
There was a problem hiding this comment.
Haven't used DevContainers before, but I imagine it would be possible to do this without relying on VS Code ?
Please correct me if I'm wrong, but I imagine we could simply exec into a running docker container as well and run CI tests from there ?
I would prefer if we not put in instructions that are IDE specific.
| ./ci/do_ci.sh {TARGET}` where the targets are: | ||
| CI tests can be run inside | ||
| [devcontainer](../CONTRIBUTING.md#devcontainer-setup-for-project) | ||
| by invoking the script |
There was a problem hiding this comment.
Could we also add a Dockerfile that creates a container with the current codebase and required dependencies to run the CI tests within that container ?
|
|
||
| FROM otel/cpp_format_tools | ||
|
|
||
| ARG GRPC_VERSION=v1.55.0 |
There was a problem hiding this comment.
Should we use the same versions in third_party_release?
Fixes #3118 (issue)
Changes
bazelisk-linux-amd64 test --copt=-DENABLE_LOGS_PREVIEW --test_output=errors --cache_test_results=no --copt=-DENABLE_TEST //exporters/otlp/...bash ci/do_ci.sh cmake.exporter.otprotocol.testFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes