Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for running CI tests locally via Docker do not work #3118

Open
psx95 opened this issue Nov 1, 2024 · 2 comments · May be fixed by #3123
Open

Instructions for running CI tests locally via Docker do not work #3118

psx95 opened this issue Nov 1, 2024 · 2 comments · May be fixed by #3123
Assignees
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@psx95
Copy link
Contributor

psx95 commented Nov 1, 2024

Based on the current instructions for running the CI tests locally, I should be able to run

./ci/run_docker.sh 

from the root of the project to enter a docker shell where I can run tests manually.

However running this command results in an error

unable to prepare context: unable to evaluate symlinks in Dockerfile path /Projects/opentelemetry-cpp/ci/Dockerfile: no such file or directory

This is probably coming from this line in the shell script which seems like it is explicitly looking for a Dockerfile in the ci directory and currently there is none.

@psx95 psx95 added the bug Something isn't working label Nov 1, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 1, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2024
@esigo esigo linked a pull request Nov 5, 2024 that will close this issue
3 tasks
@esigo
Copy link
Member

esigo commented Nov 6, 2024

@psx95 I added documentation for devcontainer here https://github.com/open-telemetry/opentelemetry-cpp/blob/ce1e82a8bfe71ae814f6e1d219515b94560ea6ce/CONTRIBUTING.md#devcontainer-setup-for-project

@dbarker
Copy link
Contributor

dbarker commented Dec 18, 2024

As a new contributor I initially hit this issue and manually copied .devcontainer from #3123 to test my PRs locally. It's been very helpful.

In addition to the ./ci/run_docker.sh script not working as mentioned above. The targets for do_ci.sh seem to have changed and documentation needs to be updated. For example ./do_ci.sh cmake.maintainer.test doesn't work but other maintainer test targets do (cmake.maintainer.sync.test among others).

Happy to help on documentation or testing for the PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants