Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes based batching for metrics #12550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for metrics.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

@iblancasa iblancasa requested review from bogdandrutu, dmitryax and a team as code owners March 4, 2025 15:21
@iblancasa
Copy link
Contributor Author

#12519 (review)

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 91.63498% with 22 lines in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (e43c36c) to head (b257e39).

Files with missing lines Patch % Lines
pdata/pmetric/pb.go 0.00% 14 Missing ⚠️
exporter/exporterhelper/metrics_batch.go 96.01% 7 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (91.63%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12550      +/-   ##
==========================================
- Coverage   92.21%   92.17%   -0.04%     
==========================================
  Files         469      470       +1     
  Lines       25368    25537     +169     
==========================================
+ Hits        23392    23539     +147     
- Misses       1568     1589      +21     
- Partials      408      409       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 4, 2025
@dmitryax
Copy link
Member

dmitryax commented Mar 4, 2025

Thanks, @iblancasa. Please adopt the recent changes made in #12548

Signed-off-by: Israel Blancas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants