Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes based batching for profiles #12564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for metrics.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

Related PRs:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 73.88060% with 35 lines in your changes missing coverage. Please review.

Project coverage is 92.06%. Comparing base (e43c36c) to head (84d2ecc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/exporterhelper/internal/sizer/profiles_sizer.go 0.00% 16 Missing ⚠️
...r/exporterhelper/xexporterhelper/profiles_batch.go 86.59% 11 Missing and 2 partials ⚠️
pdata/pprofile/pb.go 40.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (73.88%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12564      +/-   ##
==========================================
- Coverage   92.21%   92.06%   -0.15%     
==========================================
  Files         469      470       +1     
  Lines       25368    25468     +100     
==========================================
+ Hits        23392    23447      +55     
- Misses       1568     1609      +41     
- Partials      408      412       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi requested a review from sfc-gh-sili March 5, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant