Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Spelling receiver #37134

Open
wants to merge 150 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
150 commits
Select commit Hold shift + click to select a range
c9bb7da
spelling: a
jsoref Jan 6, 2025
ca8be2a
spelling: adapted
jsoref Jan 5, 2025
e9e964f
spelling: address
jsoref Jan 5, 2025
f5b5393
spelling: and
jsoref Jan 7, 2025
97dc70c
spelling: associated
jsoref Jan 5, 2025
2298908
spelling: asynchronously
jsoref Jan 5, 2025
da9c7d6
spelling: attachment
jsoref Jan 5, 2025
cea00f9
spelling: attribute
jsoref Jan 5, 2025
1dbccc3
spelling: authenticated
jsoref Jan 5, 2025
ec6adac
spelling: authentication
jsoref Jan 5, 2025
8c6be6d
spelling: because
jsoref Jan 5, 2025
32064dd
spelling: before
jsoref Jan 5, 2025
c1703ea
spelling: below
jsoref Jan 5, 2025
a13dca0
spelling: bypasses
jsoref Jan 5, 2025
21b0fee
spelling: cannot
jsoref Jan 3, 2025
f46ce94
spelling: case-insensitive
jsoref Jan 3, 2025
222a1ff
spelling: certificate
jsoref Jan 5, 2025
5b4b655
spelling: client
jsoref Jan 5, 2025
4efa277
spelling: collect
jsoref Jan 6, 2025
624a85f
spelling: committed
jsoref Jan 6, 2025
2c6ae1a
spelling: common
jsoref Jan 6, 2025
3d4f429
spelling: component
jsoref Jan 6, 2025
463b881
spelling: config
jsoref Jan 6, 2025
eb0b78d
spelling: configuration
jsoref Jan 8, 2025
f56d5ba
spelling: connect
jsoref Jan 6, 2025
a4481a2
spelling: connection
jsoref Jan 6, 2025
f9b3acf
spelling: consumer
jsoref Jan 6, 2025
32aa55a
spelling: could
jsoref Jan 6, 2025
8aff2f3
spelling: creator
jsoref Jan 6, 2025
40aa9dd
spelling: daemonset
jsoref Jan 6, 2025
4f52835
spelling: descriptor
jsoref Jan 6, 2025
6249743
spelling: dimension
jsoref Jan 7, 2025
6771d15
spelling: distinct
jsoref Jan 7, 2025
e692d81
spelling: distinguished
jsoref Jan 7, 2025
4025dec
spelling: dropped
jsoref Jan 7, 2025
f413afc
spelling: duration
jsoref Jan 7, 2025
962f02a
spelling: endpoint
jsoref Jan 7, 2025
c07b780
spelling: endpoints
jsoref Jan 7, 2025
ee2cefb
spelling: english
jsoref Jan 7, 2025
aa895da
spelling: escaped
jsoref Jan 7, 2025
104e3fc
spelling: event
jsoref Jan 7, 2025
764169f
spelling: exceeds
jsoref Jan 7, 2025
4484077
spelling: exclude
jsoref Jan 7, 2025
8d9d5ee
spelling: excluded
jsoref Jan 7, 2025
ed836f6
spelling: expected
jsoref Jan 7, 2025
b27eba9
spelling: factory
jsoref Jan 8, 2025
8106308
spelling: failed
jsoref Jan 7, 2025
257aac6
spelling: falsepos
jsoref Jan 7, 2025
14a9b01
spelling: flakiness
jsoref Jan 7, 2025
38a277a
spelling: functions
jsoref Jan 7, 2025
ce69f86
spelling: gauge
jsoref Jan 7, 2025
1269d79
spelling: github
jsoref Jan 3, 2025
a48a7dd
spelling: greater
jsoref Jan 3, 2025
b20b39a
spelling: handler
jsoref Jan 7, 2025
bbe5c94
spelling: hardware
jsoref Jan 7, 2025
ba2ddb7
spelling: histogram
jsoref Jan 7, 2025
4ef8bec
spelling: histograms
jsoref Jan 7, 2025
1617935
spelling: in-sync
jsoref Jan 7, 2025
8b94df8
spelling: include
jsoref Jan 7, 2025
c1c3313
spelling: indeed
jsoref Jan 7, 2025
3ef6625
spelling: info-creator
jsoref Jan 7, 2025
cbdc5a6
spelling: insert
jsoref Jan 7, 2025
d2b857c
spelling: instrumentation
jsoref Jan 7, 2025
1ef34bc
spelling: kubelet
jsoref Jan 7, 2025
d229466
spelling: kubernetes
jsoref Jan 7, 2025
fdc95d2
spelling: lock
jsoref Jan 7, 2025
26aba88
spelling: macos
jsoref Jan 3, 2025
6d9971e
spelling: measurement
jsoref Jan 8, 2025
52cdf95
spelling: mechanism
jsoref Jan 8, 2025
4ada0c4
spelling: message
jsoref Jan 7, 2025
99f380c
spelling: metadata
jsoref Jan 8, 2025
77a2b4e
spelling: metrics
jsoref Jan 7, 2025
c7f3008
spelling: metricsbuilder
jsoref Jan 7, 2025
620b407
spelling: metricstransform
jsoref Jan 8, 2025
03435c1
spelling: minimum
jsoref Jan 7, 2025
feb262a
spelling: mismatch
jsoref Jan 7, 2025
12e5b8d
spelling: mountpoints
jsoref Jan 7, 2025
23cb47f
spelling: must
jsoref Jan 3, 2025
91601e1
spelling: nonexistent
jsoref Jan 3, 2025
5fdc9aa
spelling: nonexistent_pvc
jsoref Jan 7, 2025
85721f4
spelling: occurred
jsoref Jan 8, 2025
c6ae963
spelling: opentelemetry
jsoref Jan 7, 2025
2b0cf20
spelling: other
jsoref Jan 8, 2025
2e6bb9f
spelling: parsable
jsoref Jan 8, 2025
f679fc7
spelling: particular
jsoref Jan 8, 2025
50c324b
spelling: partition
jsoref Jan 8, 2025
0e19c4c
spelling: permanent
jsoref Jan 7, 2025
0a319a0
spelling: pipeline
jsoref Jan 8, 2025
0b4de4e
spelling: prefix
jsoref Jan 7, 2025
4415a13
spelling: privileges
jsoref Jan 8, 2025
cbee3ee
spelling: propagated
jsoref Jan 8, 2025
ba856c4
spelling: provider
jsoref Jan 7, 2025
4e83da6
spelling: querier
jsoref Jan 7, 2025
b5d80ea
spelling: received
jsoref Jan 7, 2025
0b4229a
spelling: receiver
jsoref Jan 7, 2025
452b52e
spelling: receiving
jsoref Jan 7, 2025
60b3d35
spelling: record
jsoref Jan 7, 2025
b8dd052
spelling: replaces
jsoref Jan 7, 2025
2f2ec73
spelling: replicas
jsoref Jan 7, 2025
0da89a8
spelling: request
jsoref Jan 7, 2025
3102927
spelling: response
jsoref Jan 7, 2025
00288b2
spelling: retrieve
jsoref Jan 7, 2025
3b28952
spelling: schemes
jsoref Jan 7, 2025
d688253
spelling: scraper
jsoref Jan 7, 2025
46dae28
spelling: see below for the
jsoref Jan 10, 2025
4bbb301
spelling: segment
jsoref Jan 7, 2025
6486edc
spelling: segments
jsoref Jan 7, 2025
4461001
spelling: service
jsoref Jan 7, 2025
40ccb3d
spelling: shuts down
jsoref Jan 7, 2025
125b33d
spelling: similar
jsoref Jan 8, 2025
cb7edfc
spelling: skywalking
jsoref Jan 7, 2025
949a153
spelling: splitlist
jsoref Jan 8, 2025
642b7fc
spelling: stateset
jsoref Jan 7, 2025
205f530
spelling: string
jsoref Jan 7, 2025
a66811d
spelling: success
jsoref Jan 7, 2025
c790784
spelling: suffix
jsoref Jan 8, 2025
88db62b
spelling: synced
jsoref Jan 8, 2025
6cebfc2
spelling: synthetic
jsoref Jan 8, 2025
dd8b2d3
spelling: telemetry
jsoref Jan 8, 2025
69a480c
spelling: that
jsoref Jan 3, 2025
a5b11b2
spelling: the
jsoref Jan 3, 2025
7b8a5fc
spelling: timeout
jsoref Jan 8, 2025
78ef9de
spelling: tracesunmarshaller
jsoref Jan 10, 2025
baeecd4
spelling: unacked
jsoref Jan 7, 2025
72a23be
spelling: unmarshal
jsoref Jan 8, 2025
8af20b3
spelling: used
jsoref Jan 8, 2025
bb65325
spelling: utilization
jsoref Jan 7, 2025
bc044e9
spelling: value
jsoref Jan 8, 2025
d9f9176
spelling: versions
jsoref Jan 8, 2025
5ee84f9
spelling: wavefront
jsoref Jan 7, 2025
1de7bba
spelling: whether
jsoref Jan 7, 2025
5e2c531
spelling: won't
jsoref Jan 8, 2025
ea339c2
link: full list of `ServerConfig`
jsoref Jan 3, 2025
f5ef6af
link: By default, insecure settings are rejected and certificate veri…
jsoref Jan 5, 2025
0effe6b
link: DefaultMetricSettings
jsoref Jan 5, 2025
9766dfd
link: DefaultMetricsSettings
jsoref Jan 5, 2025
396a293
link: Grafana Dashboard for metrics from this receiver is on the mark…
jsoref Jan 5, 2025
d88d4da
link: Huawei Cloud region
jsoref Jan 5, 2025
5eb1b98
link: Loki HTTP API: Ingest logs
jsoref Jan 5, 2025
a9f33ca
link: Prometheus license
jsoref Jan 5, 2025
6c9cca5
link: apache scoreboard
jsoref Jan 5, 2025
9a77ce4
link: experimentalmetricmetadata/metadata.go
jsoref Jan 5, 2025
31e16c8
link: go sdk's default authentication mechanism
jsoref Jan 5, 2025
a3be39f
link: in-depth documentation on the allowable metrics
jsoref Jan 5, 2025
e838ef7
link: metadata.yaml
jsoref Jan 5, 2025
ef70b6e
link: node conditions
jsoref Jan 5, 2025
60b3ec2
link: opentelemetry-collector-contrib#23565
jsoref Jan 5, 2025
af60bca
link: signalfx/sapm-proto
jsoref Jan 5, 2025
243dfc4
link: sql/database
jsoref Jan 5, 2025
7b60f5b
link: config.go
jsoref Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/aws/xray/tracesegment.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,22 @@ type Segment struct {
// Validate checks whether the segment is valid or not
func (s *Segment) Validate() error {
if s.Name == nil {
return errors.New(`segment "name" can not be nil`)
return errors.New(`segment "name" cannot be nil`)
}

if s.ID == nil {
return errors.New(`segment "id" can not be nil`)
return errors.New(`segment "id" cannot be nil`)
}

if s.StartTime == nil {
return errors.New(`segment "start_time" can not be nil`)
return errors.New(`segment "start_time" cannot be nil`)
}

// it's ok for embedded subsegments to not have trace_id
// but the root segment and independent subsegments must all
// have trace_id.
if s.TraceID == nil {
return errors.New(`segment "trace_id" can not be nil`)
return errors.New(`segment "trace_id" cannot be nil`)
}

return nil
Expand Down
10 changes: 5 additions & 5 deletions internal/aws/xray/tracesegment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ func TestTraceBodyUnMarshalling(t *testing.T) {

for _, tc := range tests {
content, err := os.ReadFile(tc.samplePath)
assert.NoErrorf(t, err, "[%s] can not read raw segment", tc.testCase)
assert.NoErrorf(t, err, "[%s] cannot read raw segment", tc.testCase)

assert.NotEmptyf(t, content, "[%s] content length is 0", tc.testCase)

Expand All @@ -647,22 +647,22 @@ func TestValidate(t *testing.T) {
{
testCase: "missing segment name",
input: &Segment{},
expectedErrorStr: `segment "name" can not be nil`,
expectedErrorStr: `segment "name" cannot be nil`,
},
{
testCase: "missing segment id",
input: &Segment{
Name: String("a name"),
},
expectedErrorStr: `segment "id" can not be nil`,
expectedErrorStr: `segment "id" cannot be nil`,
},
{
testCase: "missing segment start_time",
input: &Segment{
Name: String("a name"),
ID: String("an ID"),
},
expectedErrorStr: `segment "start_time" can not be nil`,
expectedErrorStr: `segment "start_time" cannot be nil`,
},
{
testCase: "missing segment trace_id",
Expand All @@ -671,7 +671,7 @@ func TestValidate(t *testing.T) {
ID: String("an ID"),
StartTime: aws.Float64(10),
},
expectedErrorStr: `segment "trace_id" can not be nil`,
expectedErrorStr: `segment "trace_id" cannot be nil`,
},
{
testCase: "happy case",
Expand Down
4 changes: 2 additions & 2 deletions receiver/activedirectorydsreceiver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The `active_directory_ds` receiver scrapes metric relating to an Active Director

## Configuration
The following settings are optional:
- `metrics` (default: see `DefaultMetricsSettings` [here](./internal/metadata/generated_metrics.go)): Allows enabling and disabling specific metrics from being collected in this receiver.
- `metrics` (default: see [`DefaultMetricsSettings`](./internal/metadata/generated_metrics.go)): Allows enabling and disabling specific metrics from being collected in this receiver.
- `collection_interval` (default = `10s`): The interval at which metrics are emitted by this receiver.
- `initial_delay` (default = `1s`): defines how long this receiver waits before starting.

Expand All @@ -31,7 +31,7 @@ receivers:
active_directory.ds.replication.network.io: false
```

The full list of settings exposed for this receiver are documented [here](./config.go) with detailed sample configurations [here](./testdata/config.yaml).
The full list of settings exposed for this receiver are documented in [config.go](./config.go) with detailed sample configurations in [testdata/config.yaml](./testdata/config.yaml).

## Metrics

Expand Down
12 changes: 6 additions & 6 deletions receiver/activedirectorydsreceiver/counters.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const (
dsNotifyQueueSize = "DS Notify Queue Size"
dsSecurityDescriptorPropagationsEvents = "DS Security Descriptor Propagations Events"
dsSearchSubOperations = "DS Search sub-operations/sec"
dsSecurityDescripterSubOperations = "DS Security Descriptor sub-operations/sec"
dsSecurityDescriptorSubOperations = "DS Security Descriptor sub-operations/sec"
dsThreadsInUse = "DS Threads in Use"
ldapClientSessions = "LDAP Client Sessions"
ldapBindTime = "LDAP Bind Time"
Expand Down Expand Up @@ -81,7 +81,7 @@ func (w *watchers) Close() error {
return err
}

func getWatchers(wc watcherCreater) (*watchers, error) {
func getWatchers(wc watcherCreator) (*watchers, error) {
var err error

w := &watchers{
Expand Down Expand Up @@ -192,7 +192,7 @@ func getWatchers(wc watcherCreater) (*watchers, error) {
return nil, err
}

if w.counterNameToWatcher[dsSecurityDescripterSubOperations], err = wc.Create(dsSecurityDescripterSubOperations); err != nil {
if w.counterNameToWatcher[dsSecurityDescriptorSubOperations], err = wc.Create(dsSecurityDescriptorSubOperations); err != nil {
return nil, err
}

Expand All @@ -219,7 +219,7 @@ func getWatchers(wc watcherCreater) (*watchers, error) {
return w, nil
}

type watcherCreater interface {
type watcherCreator interface {
Create(counterName string) (winperfcounters.PerfCounterWatcher, error)
}

Expand All @@ -228,8 +228,8 @@ const (
object = "DirectoryServices"
)

type defaultWatcherCreater struct{}
type defaultWatcherCreator struct{}

func (defaultWatcherCreater) Create(counterName string) (winperfcounters.PerfCounterWatcher, error) {
func (defaultWatcherCreator) Create(counterName string) (winperfcounters.PerfCounterWatcher, error) {
return winperfcounters.NewWatcher(object, instanceName, counterName)
}
6 changes: 3 additions & 3 deletions receiver/activedirectorydsreceiver/counters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

func TestGetWatchers(t *testing.T) {
c := &mockCounterCreater{
c := &mockCounterCreator{
availableCounterNames: getAvailableCounters(t),
}

Expand All @@ -46,12 +46,12 @@ func getAvailableCounters(t *testing.T) []string {
return linesOut
}

type mockCounterCreater struct {
type mockCounterCreator struct {
created int
availableCounterNames []string
}

func (m *mockCounterCreater) Create(counterName string) (winperfcounters.PerfCounterWatcher, error) {
func (m *mockCounterCreator) Create(counterName string) (winperfcounters.PerfCounterWatcher, error) {
for _, availableCounter := range m.availableCounterNames {
if counterName == availableCounter {
watcher := &mockPerfCounterWatcher{
Expand Down
2 changes: 1 addition & 1 deletion receiver/activedirectorydsreceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ The number of values transmitted by the Directory Replication Agent per second.
| Name | Description | Values |
| ---- | ----------- | ------ |
| direction | The direction of data flow. | Str: ``sent``, ``received`` |
| type | The type of value sent. | Str: ``distingushed_names``, ``other`` |
| type | The type of value sent. | Str: ``distinguished_names``, ``other`` |

### active_directory.ds.security_descriptor_propagations_event.queued

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion receiver/activedirectorydsreceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ attributes:
description: The type of value sent.
type: string
enum:
- distingushed_names
- distinguished_names
- other
operation_type:
name_override: type
Expand Down
14 changes: 7 additions & 7 deletions receiver/activedirectorydsreceiver/scraper.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func newActiveDirectoryDSScraper(mbc metadata.MetricsBuilderConfig, params recei
}

func (a *activeDirectoryDSScraper) start(_ context.Context, _ component.Host) error {
watchers, err := getWatchers(defaultWatcherCreater{})
watchers, err := getWatchers(defaultWatcherCreator{})
if err != nil {
return fmt.Errorf("failed to create performance counter watchers: %w", err)
}
Expand Down Expand Up @@ -106,7 +106,7 @@ func (a *activeDirectoryDSScraper) scrape(_ context.Context) (pmetric.Metrics, e
draInboundValuesDNs, dnsErr := a.w.Scrape(draInboundValuesDNs)
multiErr = multierr.Append(multiErr, dnsErr)
if dnsErr == nil {
a.mb.RecordActiveDirectoryDsReplicationValueRateDataPoint(now, draInboundValuesDNs, metadata.AttributeDirectionReceived, metadata.AttributeValueTypeDistingushedNames)
a.mb.RecordActiveDirectoryDsReplicationValueRateDataPoint(now, draInboundValuesDNs, metadata.AttributeDirectionReceived, metadata.AttributeValueTypeDistinguishedNames)
}

draInboundValuesTotal, totalErr := a.w.Scrape(draInboundValuesTotal)
Expand All @@ -120,7 +120,7 @@ func (a *activeDirectoryDSScraper) scrape(_ context.Context) (pmetric.Metrics, e
draOutboundValuesDNs, dnsErr := a.w.Scrape(draOutboundValuesDNs)
multiErr = multierr.Append(multiErr, dnsErr)
if dnsErr == nil {
a.mb.RecordActiveDirectoryDsReplicationValueRateDataPoint(now, draOutboundValuesDNs, metadata.AttributeDirectionSent, metadata.AttributeValueTypeDistingushedNames)
a.mb.RecordActiveDirectoryDsReplicationValueRateDataPoint(now, draOutboundValuesDNs, metadata.AttributeDirectionSent, metadata.AttributeValueTypeDistinguishedNames)
}

draOutboundValuesTotal, totalErr := a.w.Scrape(draOutboundValuesTotal)
Expand All @@ -136,10 +136,10 @@ func (a *activeDirectoryDSScraper) scrape(_ context.Context) (pmetric.Metrics, e
a.mb.RecordActiveDirectoryDsReplicationOperationPendingDataPoint(now, int64(draPendingReplicationOperations))
}

draSyncFailuresSchemaMistmatch, schemaMismatchErr := a.w.Scrape(draSyncFailuresSchemaMismatch)
draSyncFailuresSchemaMismatch, schemaMismatchErr := a.w.Scrape(draSyncFailuresSchemaMismatch)
multiErr = multierr.Append(multiErr, schemaMismatchErr)
if schemaMismatchErr == nil {
a.mb.RecordActiveDirectoryDsReplicationSyncRequestCountDataPoint(now, int64(draSyncFailuresSchemaMistmatch), metadata.AttributeSyncResultSchemaMismatch)
a.mb.RecordActiveDirectoryDsReplicationSyncRequestCountDataPoint(now, int64(draSyncFailuresSchemaMismatch), metadata.AttributeSyncResultSchemaMismatch)
}

draSyncRequestsSuccessful, requestsSuccessfulErr := a.w.Scrape(draSyncRequestsSuccessful)
Expand All @@ -151,7 +151,7 @@ func (a *activeDirectoryDSScraper) scrape(_ context.Context) (pmetric.Metrics, e
draSyncRequestsTotal, totalErr := a.w.Scrape(draSyncRequestsMade)
multiErr = multierr.Append(multiErr, totalErr)
if totalErr == nil && requestsSuccessfulErr == nil && schemaMismatchErr == nil {
otherReplicationSyncRequests := draSyncRequestsTotal - draSyncRequestsSuccessful - draSyncFailuresSchemaMistmatch
otherReplicationSyncRequests := draSyncRequestsTotal - draSyncRequestsSuccessful - draSyncFailuresSchemaMismatch
a.mb.RecordActiveDirectoryDsReplicationSyncRequestCountDataPoint(now, int64(otherReplicationSyncRequests), metadata.AttributeSyncResultOther)
}

Expand Down Expand Up @@ -203,7 +203,7 @@ func (a *activeDirectoryDSScraper) scrape(_ context.Context) (pmetric.Metrics, e
a.mb.RecordActiveDirectoryDsSecurityDescriptorPropagationsEventQueuedDataPoint(now, int64(securityPropEvents))
}

securityDescSubops, err := a.w.Scrape(dsSecurityDescripterSubOperations)
securityDescSubops, err := a.w.Scrape(dsSecurityDescriptorSubOperations)
multiErr = multierr.Append(multiErr, err)
if err == nil {
a.mb.RecordActiveDirectoryDsSuboperationRateDataPoint(now, securityDescSubops, metadata.AttributeSuboperationTypeSecurityDescriptorPropagationsEvent)
Expand Down
8 changes: 4 additions & 4 deletions receiver/activedirectorydsreceiver/scraper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestScrape(t *testing.T) {
t.Run("Fully successful scrape", func(t *testing.T) {
t.Parallel()

mockWatchers, err := getWatchers(&mockCounterCreater{
mockWatchers, err := getWatchers(&mockCounterCreator{
availableCounterNames: getAvailableCounters(t),
})
require.NoError(t, err)
Expand Down Expand Up @@ -59,7 +59,7 @@ func TestScrape(t *testing.T) {
fullSyncObjectsRemainingErr := errors.New("failed to scrape sync objects remaining")
draInboundValuesDNErr := errors.New("failed to scrape sync inbound value DNs")

mockWatchers, err := getWatchers(&mockCounterCreater{
mockWatchers, err := getWatchers(&mockCounterCreator{
availableCounterNames: getAvailableCounters(t),
})
require.NoError(t, err)
Expand Down Expand Up @@ -94,7 +94,7 @@ func TestScrape(t *testing.T) {
fullSyncObjectsRemainingErr := errors.New("failed to close sync objects remaining")
draInboundValuesDNErr := errors.New("failed to close sync inbound value DNs")

mockWatchers, err := getWatchers(&mockCounterCreater{
mockWatchers, err := getWatchers(&mockCounterCreator{
availableCounterNames: getAvailableCounters(t),
})
require.NoError(t, err)
Expand All @@ -115,7 +115,7 @@ func TestScrape(t *testing.T) {
t.Run("Double shutdown does not error", func(t *testing.T) {
t.Parallel()

mockWatchers, err := getWatchers(&mockCounterCreater{
mockWatchers, err := getWatchers(&mockCounterCreator{
availableCounterNames: getAvailableCounters(t),
})
require.NoError(t, err)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ resourceMetrics:
stringValue: received
- key: type
value:
stringValue: distingushed_names
stringValue: distinguished_names
startTimeUnixNano: "1000000"
timeUnixNano: "1000000"
- asDouble: 1
Expand All @@ -266,7 +266,7 @@ resourceMetrics:
stringValue: sent
- key: type
value:
stringValue: distingushed_names
stringValue: distinguished_names
startTimeUnixNano: "1000000"
timeUnixNano: "1000000"
- asDouble: 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ resourceMetrics:
stringValue: sent
- key: type
value:
stringValue: distingushed_names
stringValue: distinguished_names
startTimeUnixNano: "1000000"
timeUnixNano: "1000000"
- asDouble: 1
Expand Down
2 changes: 1 addition & 1 deletion receiver/aerospikereceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Number of cell coverings for query region queried. Aerospike metric geo_region_q

Number of points outside the region.

Total query result points is geo_region_query_points + geo_region_query_falsepos. Aerospike metric geo_regio_query_falspos.
Total query result points is geo_region_query_points + geo_region_query_falsepos. Aerospike metric geo_regio_query_falsepos.

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
Expand Down
2 changes: 1 addition & 1 deletion receiver/aerospikereceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ metrics:
enabled: true
description: Number of points outside the region.
unit: '{points}'
extended_documentation: Total query result points is geo_region_query_points + geo_region_query_falsepos. Aerospike metric geo_regio_query_falspos.
extended_documentation: Total query result points is geo_region_query_points + geo_region_query_falsepos. Aerospike metric geo_regio_query_falsepos.
sum:
value_type: int
input_type: string
Expand Down
2 changes: 1 addition & 1 deletion receiver/apachereceiver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ receivers:
endpoint: "http://localhost:8080/server-status?auto"
```

The full list of settings exposed for this receiver are documented [here](./config.go) with detailed sample configurations [here](./testdata/config.yaml).
The full list of settings exposed for this receiver are documented in [config.go](./config.go) with detailed sample configurations in [testdata/config.yaml](./testdata/config.yaml).

## Metrics

Expand Down
2 changes: 1 addition & 1 deletion receiver/apachereceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ The number of requests serviced by the HTTP server per second.

The number of workers in each state.

The apache scoreboard is an encoded representation of the state of all the server's workers. This metric decodes the scoreboard and presents a count of workers in each state. Additional details can be found [here](https://metacpan.org/pod/Apache::Scoreboard#DESCRIPTION).
The [apache scoreboard](https://metacpan.org/pod/Apache::Scoreboard#DESCRIPTION) is an encoded representation of the state of all the server's workers. This metric decodes the scoreboard and presents a count of workers in each state.

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
Expand Down
4 changes: 2 additions & 2 deletions receiver/apachereceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ metrics:
enabled: true
description: The number of workers in each state.
extended_documentation: >-
The apache scoreboard is an encoded representation of the state of all the server's workers.
The [apache scoreboard](https://metacpan.org/pod/Apache::Scoreboard#DESCRIPTION)
is an encoded representation of the state of all the server's workers.
This metric decodes the scoreboard and presents a count of workers in each state.
Additional details can be found [here](https://metacpan.org/pod/Apache::Scoreboard#DESCRIPTION).
unit: "{workers}"
sum:
value_type: int
Expand Down
Loading
Loading