[chore] Spelling receiver #37134
Open
[chore] Spelling receiver #37134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
requested review from
a team,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole,
atoulme,
djaglowski,
jmacd,
dmitryax,
fatsheep9146,
jpkrohling,
TylerHelmuth,
ChrsMark,
mwear,
codeboten and
mx-psi
as code owners
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
…fication is on Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
…etplace Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
force-pushed
the
spelling-receiver
branch
from
a0c9de0 to
7b60f5b
Compare
| @@ -1443,7 +1443,7 @@ type CommitComment implements Node & Comment & Deletable & Minimizable & Updatab | |||
| viewerCanReact: Boolean! | |||
| "Check if the current viewer can update this object." | |||
| viewerCanUpdate: Boolean! | |||
| "Reasons why the current viewer can not update this comment." | |||
| "Reasons why the current viewer cannot update this comment." | |||
There was a problem hiding this comment.
Hm I believe this is a generated file, but there is no header on the file saying so. @adrielp can you confirm?
I think if the file is autogenerated then we don't want to modify it?
There was a problem hiding this comment.
I thought I dropped this somewhere...
|
If you're talking about https://pkg.go.dev/github.com/golangci/misspell:
check-spelling works against a full dictionary as opposed to just common misspellings. It's closer to cspell (but I'm currently working on one of the opentelemetry repositories that uses cspell, and I'm fixing a handful of typos there too...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix spelling in receiver/
#37128 (review)
Link to tracking issue