Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/signatometrics]Add core logic for signal to metrics #36852

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
241 changes: 224 additions & 17 deletions connector/signaltometricsconnector/connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,46 +5,253 @@ package signaltometricsconnector // import "github.com/open-telemetry/openteleme

import (
"context"
"errors"
"fmt"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/connector"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/plog"
"go.opentelemetry.io/collector/pdata/pmetric"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.uber.org/zap"

"github.com/open-telemetry/opentelemetry-collector-contrib/connector/signaltometricsconnector/internal/aggregator"
"github.com/open-telemetry/opentelemetry-collector-contrib/connector/signaltometricsconnector/internal/model"
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottldatapoint"
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottllog"
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlspan"
)

type signalToMetrics struct {
next consumer.Metrics
logger *zap.Logger

spanMetricDefs []model.MetricDef[ottlspan.TransformContext]
dpMetricDefs []model.MetricDef[ottldatapoint.TransformContext]
logMetricDefs []model.MetricDef[ottllog.TransformContext]

component.StartFunc
component.ShutdownFunc
}

func newSignalToMetrics(
set connector.Settings,
next consumer.Metrics,
) *signalToMetrics {
return &signalToMetrics{
logger: set.Logger,
next: next,
}
}

func (sm *signalToMetrics) Capabilities() consumer.Capabilities {
return consumer.Capabilities{MutatesData: false}
}

func (sm *signalToMetrics) ConsumeTraces(context.Context, ptrace.Traces) error {
return nil
func (sm *signalToMetrics) ConsumeTraces(ctx context.Context, td ptrace.Traces) error {
if len(sm.spanMetricDefs) == 0 {
return nil
}

var multiError error
processedMetrics := pmetric.NewMetrics()
processedMetrics.ResourceMetrics().EnsureCapacity(td.ResourceSpans().Len())
aggregator := aggregator.NewAggregator[ottlspan.TransformContext](processedMetrics)

for i := 0; i < td.ResourceSpans().Len(); i++ {
resourceSpan := td.ResourceSpans().At(i)
resourceAttrs := resourceSpan.Resource().Attributes()
for j := 0; j < resourceSpan.ScopeSpans().Len(); j++ {
scopeSpan := resourceSpan.ScopeSpans().At(j)
for k := 0; k < scopeSpan.Spans().Len(); k++ {
span := scopeSpan.Spans().At(k)
spanAttrs := span.Attributes()
for _, md := range sm.spanMetricDefs {
filteredSpanAttrs, ok := md.FilterAttributes(spanAttrs)
if !ok {
continue
}

// The transform context is created from original attributes so that the
// OTTL expressions are also applied on the original attributes.
tCtx := ottlspan.NewTransformContext(span, scopeSpan.Scope(), resourceSpan.Resource(), scopeSpan, resourceSpan)
if md.Conditions != nil {
match, err := md.Conditions.Eval(ctx, tCtx)
if err != nil {
multiError = errors.Join(multiError, fmt.Errorf("failed to evaluate conditions, skipping: %w", err))
continue
}
if !match {
sm.logger.Debug("condition not matched, skipping", zap.String("name", md.Key.Name))
continue
}
}

filteredResAttrs := md.FilterResourceAttributes(resourceAttrs)
multiError = errors.Join(multiError, aggregator.Aggregate(ctx, tCtx, md, filteredResAttrs, filteredSpanAttrs, 1))
}
}
}
}
aggregator.Finalize(sm.spanMetricDefs)
return sm.processNext(ctx, processedMetrics, multiError)
}

func (sm *signalToMetrics) ConsumeMetrics(context.Context, pmetric.Metrics) error {
return nil
func (sm *signalToMetrics) ConsumeMetrics(ctx context.Context, m pmetric.Metrics) error {
if len(sm.dpMetricDefs) == 0 {
return nil
}

var multiError error
processedMetrics := pmetric.NewMetrics()
processedMetrics.ResourceMetrics().EnsureCapacity(m.ResourceMetrics().Len())
aggregator := aggregator.NewAggregator[ottldatapoint.TransformContext](processedMetrics)
for i := 0; i < m.ResourceMetrics().Len(); i++ {
resourceMetric := m.ResourceMetrics().At(i)
resourceAttrs := resourceMetric.Resource().Attributes()
for j := 0; j < resourceMetric.ScopeMetrics().Len(); j++ {
scopeMetric := resourceMetric.ScopeMetrics().At(j)
for k := 0; k < scopeMetric.Metrics().Len(); k++ {
metrics := scopeMetric.Metrics()
metric := metrics.At(k)
for _, md := range sm.dpMetricDefs {
filteredResAttrs := md.FilterResourceAttributes(resourceAttrs)
aggregate := func(dp any, dpAttrs pcommon.Map) error {
// The transform context is created from original attributes so that the
// OTTL expressions are also applied on the original attributes.
tCtx := ottldatapoint.NewTransformContext(dp, metric, metrics, scopeMetric.Scope(), resourceMetric.Resource(), scopeMetric, resourceMetric)
if md.Conditions != nil {
match, err := md.Conditions.Eval(ctx, tCtx)
if err != nil {
multiError = errors.Join(multiError, fmt.Errorf("failed to evaluate conditions, skipping: %w", err))
return nil
}
if !match {
sm.logger.Debug("condition not matched, skipping", zap.String("name", md.Key.Name))
return nil
}
}
return aggregator.Aggregate(ctx, tCtx, md, filteredResAttrs, dpAttrs, 1)
}

//exhaustive:enforce
switch metric.Type() {
case pmetric.MetricTypeGauge:
dps := metric.Gauge().DataPoints()
for l := 0; l < dps.Len(); l++ {
dp := dps.At(l)
filteredDPAttrs, ok := md.FilterAttributes(dp.Attributes())
if !ok {
continue
}
multiError = errors.Join(multiError, aggregate(dp, filteredDPAttrs))
}
case pmetric.MetricTypeSum:
dps := metric.Sum().DataPoints()
for l := 0; l < dps.Len(); l++ {
dp := dps.At(l)
filteredDPAttrs, ok := md.FilterAttributes(dp.Attributes())
if !ok {
continue
}
multiError = errors.Join(multiError, aggregate(dp, filteredDPAttrs))
}
case pmetric.MetricTypeSummary:
dps := metric.Summary().DataPoints()
for l := 0; l < dps.Len(); l++ {
dp := dps.At(l)
filteredDPAttrs, ok := md.FilterAttributes(dp.Attributes())
if !ok {
continue
}
multiError = errors.Join(multiError, aggregate(dp, filteredDPAttrs))
}
case pmetric.MetricTypeHistogram:
dps := metric.Histogram().DataPoints()
for l := 0; l < dps.Len(); l++ {
dp := dps.At(l)
filteredDPAttrs, ok := md.FilterAttributes(dp.Attributes())
if !ok {
continue
}
multiError = errors.Join(multiError, aggregate(dp, filteredDPAttrs))
}
case pmetric.MetricTypeExponentialHistogram:
dps := metric.ExponentialHistogram().DataPoints()
for l := 0; l < dps.Len(); l++ {
dp := dps.At(l)
filteredDPAttrs, ok := md.FilterAttributes(dp.Attributes())
if !ok {
continue
}
multiError = errors.Join(multiError, aggregate(dp, filteredDPAttrs))
}
case pmetric.MetricTypeEmpty:
multiError = errors.Join(multiError, fmt.Errorf("metric %q: invalid metric type: %v", metric.Name(), metric.Type()))
}
}
}
}
}
aggregator.Finalize(sm.dpMetricDefs)
return sm.processNext(ctx, processedMetrics, multiError)
}

func (sm *signalToMetrics) ConsumeLogs(context.Context, plog.Logs) error {
return nil
func (sm *signalToMetrics) ConsumeLogs(ctx context.Context, logs plog.Logs) error {
if len(sm.logMetricDefs) == 0 {
return nil
}

var multiError error
processedMetrics := pmetric.NewMetrics()
processedMetrics.ResourceMetrics().EnsureCapacity(logs.ResourceLogs().Len())
aggregator := aggregator.NewAggregator[ottllog.TransformContext](processedMetrics)
for i := 0; i < logs.ResourceLogs().Len(); i++ {
resourceLog := logs.ResourceLogs().At(i)
resourceAttrs := resourceLog.Resource().Attributes()
for j := 0; j < resourceLog.ScopeLogs().Len(); j++ {
scopeLog := resourceLog.ScopeLogs().At(j)
for k := 0; k < scopeLog.LogRecords().Len(); k++ {
log := scopeLog.LogRecords().At(k)
logAttrs := log.Attributes()
for _, md := range sm.logMetricDefs {
filteredLogAttrs, ok := md.FilterAttributes(logAttrs)
if !ok {
continue
}

// The transform context is created from original attributes so that the
// OTTL expressions are also applied on the original attributes.
tCtx := ottllog.NewTransformContext(log, scopeLog.Scope(), resourceLog.Resource(), scopeLog, resourceLog)
if md.Conditions != nil {
match, err := md.Conditions.Eval(ctx, tCtx)
if err != nil {
multiError = errors.Join(multiError, fmt.Errorf("failed to evaluate conditions, skipping: %w", err))
continue
}
if !match {
sm.logger.Debug("condition not matched, skipping", zap.String("name", md.Key.Name))
continue
}
}

filteredResAttrs := md.FilterResourceAttributes(resourceAttrs)
multiError = errors.Join(multiError, aggregator.Aggregate(ctx, tCtx, md, filteredResAttrs, filteredLogAttrs, 1))
}
}
}
}
aggregator.Finalize(sm.logMetricDefs)
return sm.processNext(ctx, processedMetrics, multiError)
}

// processNext is a helper method for all the Consume* methods to do error handling,
// logging, and sending the processed metrics to the next consumer in the pipeline.
func (sm *signalToMetrics) processNext(ctx context.Context, m pmetric.Metrics, err error) error {
if err != nil {
dpCount := m.DataPointCount()
if dpCount == 0 {
// No signals were consumed so return an error
return fmt.Errorf("failed to consume signal: %w", err)
}
// At least some signals were partially consumed, so log the error
ChrsMark marked this conversation as resolved.
Show resolved Hide resolved
// and pass the processed metrics to the next consumer.
sm.logger.Warn(
"failed to consume all signals, some signals were partially processed",
zap.Error(err),
zap.Int("successful_data_points", dpCount),
)
}
return sm.next.ConsumeMetrics(ctx, m)
}
Loading
Loading