Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/signatometrics]Add core logic for signal to metrics #36852

Merged

Conversation

lahsivjar
Copy link
Member

Description

Adding core logic for the signal to metrics connector.

Link to tracking issue

Related to #35930

Testing

Unit tests added

Documentation

Documentation is already added in README.

@lahsivjar
Copy link
Member Author

lahsivjar commented Dec 16, 2024

[For reviewers] I am not sure what to do with the changelog for the PR. This PR adds the core logic of the component but not sure how to add this to the changelog, so I haven't added it yet. Let me know if it is needed.

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a changelog would make sense, it's a user facing change that actually makes the component "functional" for the users.

I had a first look into the PR and overall looks good but I'd definitely need to do a second more careful pass on it (I assume there is no easy way to split the implementation into multiple PRs and the current one is quite big). If anybody else want to also review that'd be more than welcome.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@lahsivjar
Copy link
Member Author

/label -stale

@github-actions github-actions bot removed the Stale label Jan 3, 2025
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I only left a clarification question about the error handling logic.

connector/signaltometricsconnector/connector.go Outdated Show resolved Hide resolved
connector/signaltometricsconnector/factory.go Outdated Show resolved Hide resolved
connector/signaltometricsconnector/factory.go Outdated Show resolved Hide resolved
@lahsivjar lahsivjar requested a review from ChrsMark January 7, 2025 11:42
@ChrsMark
Copy link
Member

ChrsMark commented Jan 8, 2025

@lahsivjar please take care of the conflicts. Otherwise ready to go from my side.

@lahsivjar
Copy link
Member Author

@ChrsMark resolved the conflicts.

@ChrsMark ChrsMark added the ready to merge Code review completed; ready to merge by maintainers label Jan 9, 2025
@andrzej-stencel andrzej-stencel merged commit 9da269e into open-telemetry:main Jan 9, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 9, 2025
@lahsivjar lahsivjar deleted the signaltometrics-corelogic branch January 9, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/signaltometrics ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants