Skip to content

Replace ament_target_dependencies with target_link_libraries #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 22, 2025

ament_target_dependencies is deprecated on kilted and removed in rolling, It will require a new release on rolling.

Debs are broken https://build.ros2.org/view/Rbin_uN64/job/Rbin_uN64__rmf_visualization_navgraphs__ubuntu_noble_amd64__binary/

@ahcorde ahcorde requested review from mxgrey and Yadunund May 22, 2025 11:42
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde requested a review from Yadunund May 22, 2025 22:03
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the migration!

@Yadunund Yadunund merged commit 8443640 into main May 23, 2025
2 checks passed
@Yadunund Yadunund deleted the ahcorde/rolling/replace_ament_target_dependencies branch May 23, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants