Update CI to rolling on main #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/update_ci
branch
2 times, most recently
from
80006c3 to
ec42903
Compare
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/update_ci
branch
from
ec42903 to
6962ae4
Compare
luca-della-vedova
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Didn't look at the whole diff but I'm assuming it's just pure linter output.
I guess we can close #161 then?
Would be good if you could give everything a spin to make sure nothing is broken. I used a combination of autoformatting by |
|
I gave it a spin and it seems OK. |
Yadunund
added a commit
that referenced
this pull request
Jan 29, 2024
* Update CI to rolling Signed-off-by: Yadunund <[email protected]> * Address all flake8 and pep257 errors Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]>
Merged
Yadunund
added a commit
that referenced
this pull request
Jan 29, 2024
* Support fleet-level task (#201) * update task request to include fleet_name for fleet-level task Signed-off-by: Charly Wu <[email protected]> * added DCO commit. Signed-off-by: Charly Wu <[email protected]> * simplify logic for populating request['fleet_name'] Signed-off-by: Charly Wu <[email protected]> * remove extra whitespaces. Signed-off-by: Charly Wu <[email protected]> * remove trailing whitespace. Signed-off-by: Charly Wu <[email protected]> --------- Signed-off-by: Charly Wu <[email protected]> Co-authored-by: Yadunund <[email protected]> * Update CI to rolling on main (#208) * Update CI to rolling Signed-off-by: Yadunund <[email protected]> * Address all flake8 and pep257 errors Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Set CI to iron Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Charly Wu <[email protected]> Signed-off-by: Yadunund <[email protected]> Co-authored-by: cwrx777 <[email protected]>
This was referenced Jan 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of jazzy release, this PR updates CI jobs on
mainto Rolling.colcon testwould throw a lot of errors due to failingtest_flake8andtest_pep257tests configured forrmf_demos_fleet_adapter. Instead of disabling those tests, I've updated the formatting in the codebase to comply.