Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rviz Visualization Config #67

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Conversation

Marc-Morcos
Copy link
Contributor

@Marc-Morcos Marc-Morcos commented Jul 11, 2024

The coverage demo currently doesn't have proper visualization in RVIZ. This adds that.
image

@SteveMacenski
Copy link
Member

SteveMacenski commented Jul 15, 2024

Please fix the linting errors below and provide a screen shot of what this rviz configuration looks like (for posterity) :

 /usr/bin/bash -c source /opt/ros/iron/setup.sh && ament_flake8 $(colcon list --packages-select opennav_coverage opennav_coverage_bt opennav_coverage_demo opennav_coverage_msgs opennav_coverage_navigator -p) 
    rviz_config_file = os.path.join(coverage_demo_dir, "rviz_config.rviz")
                                                       ^
Error:         launch_arguments={'namespace': '','rviz_config': rviz_config_file}.items())
                                         ^
1     E231 missing whitespace after ','
1     Q000 Double quotes found but single quotes preferred

Error: opennav_coverage_demo/launch/coverage_demo_launch.py:28:56: Q000 Double quotes found but single quotes preferred

Error: opennav_coverage_demo/launch/coverage_demo_launch.py:70:42: E231 missing whitespace after ','

@Marc-Morcos
Copy link
Contributor Author

Ok I've fixed the issues and added the image.
image

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy, thanks!

@SteveMacenski SteveMacenski merged commit 9353c9a into open-navigation:main Jul 15, 2024
6 of 7 checks passed
Marc-Morcos added a commit to Marc-Morcos/opennav_coverage that referenced this pull request Aug 19, 2024
* Add behavior tree to navigate to start before starting fields navigation

* snake case

* comments

* rviz visualization for demo

* Update rviz_config.rviz

* Linting and add to other demo
@Marc-Morcos Marc-Morcos mentioned this pull request Aug 19, 2024
SteveMacenski pushed a commit that referenced this pull request Aug 19, 2024
* Fix polygons not clearing (#72)

* Add behavior tree to navigate to start before starting fields navigation

* snake case

* comments

* rviz visualization for demo

* Update rviz_config.rviz

* Linting and add to other demo

* Fix polygons not clearing, credit to tonynajjar

---------

Co-authored-by: Marc Morcos <[email protected]>

* Rviz Visualization Config (#67)

* Add behavior tree to navigate to start before starting fields navigation

* snake case

* comments

* rviz visualization for demo

* Update rviz_config.rviz

* Linting and add to other demo

* Add behavior tree to navigate to start before starting fields navigation (#65)

* Add behavior tree to navigate to start before starting fields navigation

* snake case

* comments

* Old format for behavior tree

---------

Co-authored-by: Marc Morcos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants