Fix minor memory leaks #12031
Merged
Fix minor memory leaks #12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bosilca @bwbarrett I'm touching some fairly old code in this PR; can you guys review? |
bosilca
reviewed
Oct 30, 2023
bosilca
reviewed
Oct 30, 2023
Remove an accidental second OBJ_CONSTRUCT of a local opal_bitmap_t variable "reachable". Signed-off-by: Jeff Squyres <[email protected]>
Even if a framework has its own framework_close function, we still have to mca_base_component_unload() each component (which will be handled safely/properly, regardless of whether the component is statically linked or was opened dynamically) and then remove that component from the framework's list of components. Signed-off-by: Jeff Squyres <[email protected]>
When tearing down the BTL TCP component, use the handy OPAL_LIST_DESTRUCT macro to OBJ_RELEASE all elements of the mca_btl_tcp_component.local_ifs list and then OBJ_DESTRUCT -- not OBJ_RELEASE -- the list itself. Signed-off-by: Jeff Squyres <[email protected]>
split_and_resolve() destroys an argv as it analyzes it. Fix one case in the loop where argv[i] was accidentally neglected to be freed. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/fix-minor-memory-leaks
branch
from
5cc0db9 to
1395303
Compare
|
@bosilca @bwbarrett Updated the PR. Can you re-review? |
bosilca
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few minor memory leaks found with clang's
-fsanitize=addressoption. Refs #12019 (even though that issue is about v4.1.x).See individual commit messages for details.