v5.0.x: Fix minor memory leaks #12061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an accidental second OBJ_CONSTRUCT of a local opal_bitmap_t variable "reachable". Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit d89c462)
Even if a framework has its own framework_close function, we still have to mca_base_component_unload() each component (which will be handled safely/properly, regardless of whether the component is statically linked or was opened dynamically) and then remove that component from the framework's list of components. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 9f67859)
When tearing down the BTL TCP component, use the handy OPAL_LIST_DESTRUCT macro to OBJ_RELEASE all elements of the mca_btl_tcp_component.local_ifs list and then OBJ_DESTRUCT -- not OBJ_RELEASE -- the list itself. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 16526a2)
split_and_resolve() destroys an argv as it analyzes it. Fix one case in the loop where argv[i] was accidentally neglected to be freed. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 1395303)
|
bot:aws:recheck |
bosilca
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v5.0.x PR corresponding to main PR #12031.
See individual commit messages for details.