opal_var_dump_color_keys: fix an array overflow #11828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpol84
reviewed
Jul 18, 2023
jsquyres
approved these changes
Jul 18, 2023
ggouaillardet
force-pushed
the
topic/opal_params_core
branch
from
4b628f3 to
a79b9bc
Compare
|
@nivShpak could you please double check I correctly wrote your name in the commit message? |
|
With @devreal hint, I think that #11827 looks more correct now. |
|
Rebased this old PR to bring it up to the current tip of |
since opal_var_dump_color_keys is used with opal_argv_count() and friends, make sure is is long enough and NULL terminated Thanks to Niv Shpak for reporting this and identifying the root cause. Refs. open-mpi#11826 Signed-off-by: Gilles Gouaillardet <[email protected]>
jsquyres
force-pushed
the
topic/opal_params_core
branch
from
a79b9bc to
7b325e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since opal_var_dump_color_keys is used with opal_argv_count() and friends, make sure is is long enough and NULL terminated
Thanks to Niv Shpak for reporting this and identifying the root cause.
Refs. #11826