Don't use opal_argv_join_range() for opal_var_dump_color_keys #11829
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The join function was initially used for convinience, to print the valid keys. This was wrong, because opal_var_dump_color_keys is not a NULL-terminated array. This commit replaces it with an asprintf loop. Thanks to Niv Shpak (@nivShpak) for reporting this and identifying the root cause. Signed-off-by: George Katevenis <[email protected]>
gkatev
force-pushed
the
fix_var_dump_color_keys
branch
from
4d2cb93 to
1455fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another alternative fix for #11826 (#11827, #11828).
opal_argv_join_range()was initially used withopal_var_dump_color_keysfor convinience, to print the valid keys. This was wrong becauseopal_var_dump_color_keysis not a NULL-terminated array. This commit replaces the join call with an equivalentopal_asprintfloop.As far as I can tell this was the only place where the array was treated as a NULL-terminated one.
Thanks to Niv Shpak (@nivShpak) for reporting this and identifying the root cause.
Fixes #11826.