Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepare 1.3.3 Release #231

Merged
merged 2 commits into from
Apr 19, 2024
Merged

feat: Prepare 1.3.3 Release #231

merged 2 commits into from
Apr 19, 2024

Conversation

akash-jain-10
Copy link
Collaborator

What this PR does / why we need it :

Fixes #222 with making additionalParameters as optional in case of using managed aws and azure secrets manager.

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@akash-jain-10 akash-jain-10 self-assigned this Apr 19, 2024
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akash-jain-10 akash-jain-10 merged commit 6502d6f into main Apr 19, 2024
1 check passed
@akash-jain-10 akash-jain-10 deleted the feat/prepare-1-3-3-release branch April 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Secrets Manager not supported by the chart
2 participants