feat: Prepare 1.3.3 Release (#231)

* fix: #222 make `additionalParameters` as optional * chore: Bump Helm Chart Version for `1.3.3` Release
open-metadata · Apr 19, 2024 · 6502d6f · 6502d6f
1 parent 83b837d
commit 6502d6f
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 24 deletions.
diff --git a/charts/deps/Chart.yaml b/charts/deps/Chart.yaml
@@ -16,13 +16,13 @@ type: application
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
 
-version: 1.3.2
+version: 1.3.3
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "1.3.2"
+appVersion: "1.3.3"
 
 home: https://open-metadata.org/
 

diff --git a/charts/deps/values.yaml b/charts/deps/values.yaml
@@ -61,7 +61,7 @@ airflow:
   airflow:
     image:
       repository: docker.getcollate.io/openmetadata/ingestion
-      tag: 1.3.2
+      tag: 1.3.3
       pullPolicy: "IfNotPresent"
     executor: "KubernetesExecutor"
     config:

diff --git a/charts/openmetadata/Chart.yaml b/charts/openmetadata/Chart.yaml
@@ -16,13 +16,13 @@ type: application
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
 
-version: 1.3.2
+version: 1.3.3
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "1.3.2"
+appVersion: "1.3.3"
 
 home: https://open-metadata.org/
 

diff --git a/charts/openmetadata/README.md b/charts/openmetadata/README.md
@@ -254,7 +254,7 @@ helm install openmetadata open-metadata/openmetadata --values <<path-to-values-f
 | fullnameOverride | string | `"openmetadata"` |
 | image.pullPolicy | string | `"Always"` |
 | image.repository | string | `"docker.getcollate.io/openmetadata/server"` |
-| image.tag | string | `1.3.2` |
+| image.tag | string | `1.3.3` |
 | imagePullSecrets | list | `[]` |
 | ingress.annotations | object | `{}` |
 | ingress.className | string | `""` |

diff --git a/charts/openmetadata/templates/_helpers.tpl b/charts/openmetadata/templates/_helpers.tpl
@@ -110,17 +110,17 @@ Function to check if passed value is empty string or null value */}}
 {{/*
 OpenMetadata Configurations AWS Additional Parameters Environment Variables for Secret Manager*/}}
 {{- define "OpenMetadata.configs.secretManager.aws.additionalParameters" -}}
-{{- if .Values.openmetadata.config.secretsManager.additionalParameters.accessKeyId.secretRef }}
 {{- with .Values.openmetadata.config.secretsManager.additionalParameters.accessKeyId }}
+{{- if .secretRef }}
 - name: OM_SM_ACCESS_KEY_ID
   valueFrom:
     secretKeyRef:
       name: {{ .secretRef }}
       key: {{ .secretKey }}
 {{- end }}
 {{- end }}
-{{- if .Values.openmetadata.config.secretsManager.additionalParameters.secretAccessKey.secretRef }}
 {{- with .Values.openmetadata.config.secretsManager.additionalParameters.secretAccessKey }}
+{{- if .secretRef }}
 - name: OM_SM_ACCESS_KEY
   valueFrom:
     secretKeyRef:
@@ -134,35 +134,35 @@ OpenMetadata Configurations AWS Additional Parameters Environment Variables for
 OpenMetadata Configurations Azure Additional Parameters Environment Variables for Secret Manager
 */}}
 {{- define "OpenMetadata.configs.secretManager.azure.additionalParameters" -}}
-{{- if .Values.openmetadata.config.secretsManager.additionalParameters.clientId.secretRef }}
 {{- with .Values.openmetadata.config.secretsManager.additionalParameters.clientId }}
+{{- if .secretRef }}
 - name: OM_SM_CLIENT_ID
   valueFrom:
     secretKeyRef:
       name: {{ .secretRef }}
       key: {{ .secretKey }}
 {{- end }}
 {{- end }}
-{{- if .Values.openmetadata.config.secretsManager.additionalParameters.clientSecret.secretRef }}
 {{- with .Values.openmetadata.config.secretsManager.additionalParameters.clientSecret }}
+{{- if .secretRef }}
 - name: OM_SM_CLIENT_SECRET
   valueFrom:
     secretKeyRef:
       name: {{ .secretRef }}
       key: {{ .secretKey }}
 {{- end }}
 {{- end }}
-{{- if .Values.openmetadata.config.secretsManager.additionalParameters.tenantId.secretRef }}
 {{- with .Values.openmetadata.config.secretsManager.additionalParameters.tenantId }}
+{{- if .secretRef }}
 - name: OM_SM_TENANT_ID
   valueFrom:
     secretKeyRef:
       name: {{ .secretRef }}
       key: {{ .secretKey }}
 {{- end }}
 {{- end }}
-{{- if .Values.openmetadata.config.secretsManager.additionalParameters.vaultName.secretRef }}
 {{- with .Values.openmetadata.config.secretsManager.additionalParameters.vaultName }}
+{{- if .secretRef }}
 - name: OM_SM_VAULT_NAME
   valueFrom:
     secretKeyRef:

diff --git a/charts/openmetadata/values.yaml b/charts/openmetadata/values.yaml
@@ -255,24 +255,42 @@ openmetadata:
         region: ""
         # For AWS
         accessKeyId:
-          secretRef: aws-access-key-secret
-          secretKey: aws-key-secret
+          secretRef: ""
+          secretKey: ""
         secretAccessKey:
-          secretRef: aws-secret-access-key-secret
-          secretKey: aws-key-secret
+          secretRef: ""
+          secretKey: ""
+        # accessKeyId:
+        #   secretRef: aws-access-key-secret
+        #   secretKey: aws-key-secret
+        # secretAccessKey:
+        #   secretRef: aws-secret-access-key-secret
+        #   secretKey: aws-key-secret
         # For Azure
         clientId:
-          secretRef: azure-client-id-secret
-          secretKey: azure-key-secret
+          secretRef: ""
+          secretKey: ""
         clientSecret:
-          secretRef: azure-client-secret
-          secretKey: azure-key-secret
+          secretRef: ""
+          secretKey: ""
         tenantId:
-          secretRef: azure-tenant-id-secret
-          secretKey: azure-key-secret
+          secretRef: ""
+          secretKey: ""
         vaultName:
-          secretRef: azure-vault-name-secret
-          secretKey: azure-key-secret
+          secretRef: ""
+          secretKey: ""
+        # clientId:
+        #   secretRef: azure-client-id-secret
+        #   secretKey: azure-key-secret
+        # clientSecret:
+        #   secretRef: azure-client-secret
+        #   secretKey: azure-key-secret
+        # tenantId:
+        #   secretRef: azure-tenant-id-secret
+        #   secretKey: azure-key-secret
+        # vaultName:
+        #   secretRef: azure-vault-name-secret
+        #   secretKey: azure-key-secret
       # You can create Kubernetes secrets from AWS Credentials with the below command
       # kubectl create secret generic aws-key-secret \
       # --from-literal=aws-access-key-secret=<access_key_id_value> \