probe-cli: Update to quic-go v0.37.3 #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kelmenhorst there are several merge conflicts, could you make sure they are resolved? Thank you! |
bassosimone
changed the title
|
However, it seems we probably need to do more work either in this pull request or elsewhere. Here's how tests fail for me locally: I need to figure out what's the issue here. Here's how to reproduce by only running the package that fails: IIUC, there is some sort of "global" state here? |
2 tasks
kelmenhorst
added a commit
that referenced
this pull request
Sep 8, 2023
This diff fixes a bug in the webconnectivityqa tests which we discovered due to the new quic-go API panicking (#1161 (comment)). The bug was that we did not close the `QAEnv` in some of our webconnectivityqa tests. Therefore, the QUIC Server would not close the underlying UDP socket (`net.PacketConn`) and the local address of this socket would not be removed from the QUIC multiplexer. In the subsequent test case, the new quic-go API (see #1161) would panic because the local address of the server would still be registered in the global QUIC multiplexer.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff fixes a bug in the webconnectivityqa tests which we discovered due to the new quic-go API panicking (ooni#1161 (comment)). The bug was that we did not close the `QAEnv` in some of our webconnectivityqa tests. Therefore, the QUIC Server would not close the underlying UDP socket (`net.PacketConn`) and the local address of this socket would not be removed from the QUIC multiplexer. In the subsequent test case, the new quic-go API (see ooni#1161) would panic because the local address of the server would still be registered in the global QUIC multiplexer.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2492 ## Description This diff updates our QUIC code, mainly in netxlite, to quic-go v0.37.1, including the new API introduced in v0.35.0. The migration has been done according to ooni/probe#2492. Major changes: * Replaced call to `quic.DialEarlyContext` with call to `quic.DialEarly` (netxlite/quic.go). * Removed now unnecessary address string in `DialEarly` calls (netxlite/quic.go). * Replaced `quic.Listener` with `*quic.Listener` (simplequicping_test.go). * Adapted signature of `HandshakeComplete` such that it returns a channel rather than a context (quic code in netxlite, measurex, mocks). * Renamed `QUICListener` to `UDPListener`. * `quic.ConnectionState.TLS` points directly to a `tls.ConnectionState` instead of pointing to a `qtls.ConnectionState` instance. Background: Starting with Go 1.21, quic-go will use the QUIC support provided by the standard library's TLS implementation. Thus, quic-go will no longer fork crypto/tls anymore. * changed signature of `quic.Connection`'s `ReceiveMessage` method --------- Co-authored-by: Simone Basso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff updates our QUIC code, mainly in netxlite, to quic-go v0.35.1, including the new API introduced in v0.35.0.
The migration has been done according to ooni/probe#2492.
Major changes:
quic.DialEarlyContextwith call toquic.DialEarly(netxlite/quic.go).DialEarlycalls (netxlite/quic.go).quic.Listenerwith*quic.Listener(simplequicping_test.go).HandshakeCompletesuch that it returns a channel rather than a context (quic code in netxlite, measurex, mocks).QUICListenertoUDPListener.Attention: Tests using a failingMockSyscallConn(e.g. in measurexlite) fail, due to issues with closing the quic.Transport quic-go.Update (07.08.2023):
Upgraded to quic-go 0.37.3 with the following changes:
quic.ConnectionState.TLSpoints directly to atls.ConnectionStateinstead of pointing to aqtls.ConnectionStateinstance. Background: Starting with Go 1.21, quic-go will use the QUIC support provided by the standard library's TLS implementation. Thus, quic-go will no longer fork crypto/tls anymore.quic.Connection'sReceiveMessagemethod